Revert "Update ILLinkTasksVersion dependency"#31807
Merged
ViktorHofer merged 1 commit intomasterfrom Feb 5, 2020
Merged
Conversation
This reverts commit a05c599.
Member
Member
|
To link it up--the revert should fix this official build break: #31760. |
stephentoub
approved these changes
Feb 5, 2020
safern
approved these changes
Feb 5, 2020
dagood
approved these changes
Feb 5, 2020
Member
Author
|
Failures are #31809 and the openssl core-eng issue. |
trylek
added a commit
to trylek/runtime
that referenced
this pull request
Feb 10, 2020
…otnet#31807)" This reverts commit 334391b.
marek-safar
added a commit
to marek-safar/runtime
that referenced
this pull request
Feb 12, 2020
…otnet#31807)" This reverts commit 334391b.
ViktorHofer
pushed a commit
that referenced
this pull request
Feb 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #2334
Reverting to unblock official builds which were failing during signing because illink is stripping out assembly attributes from assemblies.
@safern do you know why we don't do signing dry-runs in non-official builds? Those would have captured the break.
Opened #31806 to follow-up on the right fix.
cc @marek-safar