[browser] emscripten 6.0.2 follow up by pavelsavara · Pull Request #130614 · dotnet/runtime

pavelsavara · 2026-07-13T10:45:31Z

Bump to emsdk 6.0.2 (with dotnet patches) landed in #130631

Skip adding O_NOCTTY in SystemNative_Open when targeting WASM.
Add __stack_pointer as an explicit JS-library dependency
rename isSharedArrayBuffer to arrayBufferNeedsCopy and also respect buffer.resizable

dotnet-policy-service · 2026-07-13T10:46:06Z

Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

Prepares the WASM (browser) toolchain/runtime integration for newer Emscripten behavior by (1) avoiding an unsupported open flag under WASM and (2) ensuring emscripten_stack_get_current is preserved/exported for JS/native interop.

Changes:

Skip adding O_NOCTTY in SystemNative_Open when targeting WASM.
Add emscripten_stack_get_current as an explicit JS-library dependency for browser utils and corerun WASM host code.
Export _emscripten_stack_get_current from the Emscripten link step.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
src/native/libs/System.Native/pal_io.c	Avoids `O_NOCTTY` on WASM targets to prevent unsupported flag rejection.
src/native/libs/System.Native.Browser/libSystem.Native.Browser.Utils.footer.js	Adds `emscripten_stack_get_current` to the browser utils dependency list.
src/coreclr/hosts/corerun/wasm/libCorerun.js	Adds `emscripten_stack_get_current` to corerun’s WASM dependency list.
eng/native.wasm.targets	Exports `_emscripten_stack_get_current` during browser WASM linking.

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.

Copilot

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 4 comments.

azure-pipelines · 2026-07-15T12:45:59Z

Azure Pipelines: Successfully started running 4 pipeline(s). 11 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

pavelsavara · 2026-07-15T22:06:39Z

/ba-g unrelated failures

prep

bc33730

pavelsavara added this to the 11.0.0 milestone Jul 13, 2026

pavelsavara self-assigned this Jul 13, 2026

Copilot AI review requested due to automatic review settings July 13, 2026 10:45

pavelsavara added arch-wasm WebAssembly architecture area-Host os-browser Browser variant of arch-wasm labels Jul 13, 2026

Copilot started reviewing on behalf of pavelsavara July 13, 2026 10:45 View session

Copilot AI reviewed Jul 13, 2026

View reviewed changes

Comment thread src/native/libs/System.Native/pal_io.c

pavelsavara added 2 commits July 13, 2026 12:59

-sGROWABLE_ARRAYBUFFERS=0

53035d2

resizable must copy

f1ac40c

Copilot AI review requested due to automatic review settings July 13, 2026 11:05

Copilot started reviewing on behalf of pavelsavara July 13, 2026 11:06 View session

pavelsavara mentioned this pull request Jul 13, 2026

[browser] GROWABLE_ARRAYBUFFERS #130172

Closed

Copilot AI reviewed Jul 13, 2026

View reviewed changes

Comment thread src/native/libs/System.Native/pal_io.c

Comment thread src/native/libs/System.Native.Browser/utils/memory.ts Outdated

Comment thread src/native/libs/System.Native.Browser/native/crypto.ts

fix

a0231c0

Copilot AI review requested due to automatic review settings July 13, 2026 11:45

Copilot started reviewing on behalf of pavelsavara July 13, 2026 11:45 View session

Merge branch 'main' into emscripten6_prep

cbaa51b

Copilot AI reviewed Jul 13, 2026

View reviewed changes

Comment thread src/native/libs/System.Native/pal_io.c

Comment thread src/native/libs/System.Native.Browser/utils/memory.ts

Comment thread src/native/libs/System.Native.Browser/native/crypto.ts

__stack_pointer

0245b45

Copilot AI review requested due to automatic review settings July 13, 2026 11:52

Copilot started reviewing on behalf of pavelsavara July 13, 2026 11:53 View session

Copilot AI reviewed Jul 13, 2026

View reviewed changes

Comment thread src/native/libs/System.Native.Browser/native/crypto.ts

Comment thread src/coreclr/hosts/corerun/wasm/libCorerun.js

This was referenced Jul 13, 2026

[browser] Wasm.Build.Tests timeout - Timed out after 10s waiting for 'WASM EXIT' #116697

Open

Wasm.Build.NativeRebuild.Tests.ReferenceNewAssemblyRebuildTest.ReferenceNewAssembly failure: Expected changed file: driver-gen.c #130540

Closed

Merge branch 'main' into emscripten6_prep

d79a654

Copilot AI review requested due to automatic review settings July 15, 2026 08:21

Copilot started reviewing on behalf of pavelsavara July 15, 2026 08:21 View session

Copilot AI reviewed Jul 15, 2026

View reviewed changes

Comment thread src/native/libs/System.Native.Browser/utils/memory.ts

Comment thread src/mono/browser/runtime/strings.ts

Comment thread src/mono/browser/runtime/crypto.ts

Comment thread src/native/libs/System.Native.Browser/native/crypto.ts

pavelsavara marked this pull request as ready for review July 15, 2026 12:45

pavelsavara requested review from akoeplinger, lewing and maraf as code owners July 15, 2026 12:45

pavelsavara changed the title ~~[browser] emscripten6 prep~~ [browser] emscripten 6.0.x follow up Jul 15, 2026

maraf approved these changes Jul 15, 2026

View reviewed changes

pavelsavara changed the title ~~[browser] emscripten 6.0.x follow up~~ [browser] emscripten 6.0.2 follow up Jul 15, 2026

akoeplinger approved these changes Jul 15, 2026

View reviewed changes

build-analysis Bot mentioned this pull request Jul 15, 2026

The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008

Open

3 tasks

pavelsavara merged commit 5f7b765 into dotnet:main Jul 15, 2026
177 of 181 checks passed

pavelsavara deleted the emscripten6_prep branch July 15, 2026 22:07

dotnet-maestro Bot mentioned this pull request Jul 16, 2026

[main] Source code updates from dotnet/runtime dotnet/dotnet#7778

Merged

dotnet-milestone-bot Bot modified the milestones: 11.0.0, 11.0-preview7 Jul 16, 2026

Uh oh!

Conversation

pavelsavara commented Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dotnet-policy-service Bot commented Jul 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

azure-pipelines Bot commented Jul 15, 2026

Uh oh!

pavelsavara commented Jul 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pavelsavara commented Jul 13, 2026 •

edited

Loading