Skip to content

Move SocketAsyncEngine to CoreLib so different SafeHandle types can use it.#130463

Open
tmds wants to merge 2 commits into
dotnet:mainfrom
tmds:move-epoll-socket
Open

Move SocketAsyncEngine to CoreLib so different SafeHandle types can use it.#130463
tmds wants to merge 2 commits into
dotnet:mainfrom
tmds:move-epoll-socket

Conversation

@tmds

@tmds tmds commented Jul 10, 2026

Copy link
Copy Markdown
Member

Contributes to #47631.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @karelz, @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@rzikm

rzikm commented Jul 13, 2026

Copy link
Copy Markdown
Member

What does moving this code achieve? I understand that it is a good step towards merging the engine to threadpool, I am just trying to gauge the benefit this change alone would bring if we were to squeeze it in .NET 11.

Unless we have have other areas that would immediately benefit from this move, I don't see the benefit of rushing this.

@tmds

tmds commented Jul 13, 2026

Copy link
Copy Markdown
Member Author

I don't mean to squeeze/rush.

This is the first step which unblocks/enables other areas to adopt at their own pace.

I don't think these changes are risky or complex. We have discussed and worked out the API. You can consider to include this in .NET 11 if you have time to review it. Otherwise, you can postpone to .NET 12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-System.Net.Sockets community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants