Skip to content

Disable large alloc tests on 32b targets#130382

Open
dhartglassMSFT wants to merge 3 commits into
dotnet:mainfrom
dhartglassMSFT:fix_for_127128
Open

Disable large alloc tests on 32b targets#130382
dhartglassMSFT wants to merge 3 commits into
dotnet:mainfrom
dhartglassMSFT:fix_for_127128

Conversation

@dhartglassMSFT

@dhartglassMSFT dhartglassMSFT commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Large allocation tests that fail sporadically on 32b processes. I'm extending the existing disable to cover X86 as well.

Prior to #123248 these were disabled on windows x86 (see old src/tests/baseservices/issues.targets), but that refactor erroneously dropped that.

fixes #127128

Copilot AI review requested due to automatic review settings July 8, 2026 22:42
@github-actions github-actions Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 8, 2026
@dhartglassMSFT dhartglassMSFT requested review from JulieLeeMSFT and removed request for JulieLeeMSFT July 8, 2026 22:43
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates a JIT regression test to be consistently skipped on 32-bit processes (and Apple mobile) due to unreliable large contiguous allocations, restoring/strengthening the intended disablement after earlier exclusion refactoring.

Changes:

  • Add an ActiveIssue skip in test.il for PlatformDetection.Is32BitProcess.
  • Update test.cs to skip on Is32BitProcess (instead of IsArmProcess) and also skip on IsAppleMobile.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/tests/JIT/jit64/regress/vsw/373472/test.il Adds 32-bit ActiveIssue skip alongside the existing Apple mobile skip.
src/tests/JIT/jit64/regress/vsw/373472/test.cs Adjusts skip conditions to cover 32-bit processes and Apple mobile explicitly.

Comment thread src/tests/JIT/jit64/regress/vsw/373472/test.cs Outdated
Comment thread src/tests/JIT/jit64/regress/vsw/373472/test.il
Copilot AI review requested due to automatic review settings July 8, 2026 22:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comment thread src/tests/JIT/jit64/regress/vsw/373472/test.il Outdated
Comment thread src/tests/JIT/jit64/regress/vsw/373472/test.cs Outdated
@JulieLeeMSFT

Copy link
Copy Markdown
Member

@dhartglassMSFT, I was working on this PR. I see a bit difference. Please check https://github.com/dotnet/runtime/pull/129540/changes and reconcile. Meanwhile I will close that PR.

Copilot AI review requested due to automatic review settings July 10, 2026 18:23
@dhartglassMSFT

Copy link
Copy Markdown
Contributor Author

@dhartglassMSFT, I was working on this PR. I see a bit difference. Please check https://github.com/dotnet/runtime/pull/129540/changes and reconcile. Meanwhile I will close that PR.

Thanks

The wording in that one was probably better. I matched the wording and phrasing here. I added you as a reviewer on this.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test failure: JIT/jit64/regress/vsw/373472/test_il/test_il.dll

3 participants