Disable large alloc tests on 32b targets#130382
Conversation
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
There was a problem hiding this comment.
Pull request overview
This PR updates a JIT regression test to be consistently skipped on 32-bit processes (and Apple mobile) due to unreliable large contiguous allocations, restoring/strengthening the intended disablement after earlier exclusion refactoring.
Changes:
- Add an
ActiveIssueskip intest.ilforPlatformDetection.Is32BitProcess. - Update
test.csto skip onIs32BitProcess(instead ofIsArmProcess) and also skip onIsAppleMobile.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/tests/JIT/jit64/regress/vsw/373472/test.il | Adds 32-bit ActiveIssue skip alongside the existing Apple mobile skip. |
| src/tests/JIT/jit64/regress/vsw/373472/test.cs | Adjusts skip conditions to cover 32-bit processes and Apple mobile explicitly. |
|
@dhartglassMSFT, I was working on this PR. I see a bit difference. Please check https://github.com/dotnet/runtime/pull/129540/changes and reconcile. Meanwhile I will close that PR. |
Thanks The wording in that one was probably better. I matched the wording and phrasing here. I added you as a reviewer on this. |
Large allocation tests that fail sporadically on 32b processes. I'm extending the existing disable to cover X86 as well.
Prior to #123248 these were disabled on windows x86 (see old src/tests/baseservices/issues.targets), but that refactor erroneously dropped that.
fixes #127128