Add basic handling of OptimizationPreference for crossgen2 on mobile r2r by BrzVlad · Pull Request #130300 · dotnet/runtime

BrzVlad · 2026-07-07T14:12:53Z

This also makes the r2r use the size opt (--Os) as a default on mobile.
Refactor repeated rid check by using _IsIOSLikeRid like we do in the sdk.
Disable the strip flags on debug builds, to match the sdk.
Enable --strip-debug-info and --strip-inlining-info on android release as well. --strip-il-bodies is not enabled because IL should still be needed for tiered jit.

Copilot

Pull request overview

This PR updates the Crossgen2 MSBuild targets used for ReadyToRun publishing to better align mobile (iOS-like + Android) behavior with OptimizationPreference, reduce duplicated RID checks, and adjust default stripping behavior for mobile builds.

Changes:

Introduces _IsIOSLikeRid / _IsAndroidRid helper properties and uses them to simplify mobile RID conditionals.
Defaults Crossgen2 to size-focused optimization (--Os) on mobile when OptimizationPreference is unset or Size, and uses --Ot when it is Speed (only when $(Optimize) is true).
Applies Crossgen2 --strip-debug-info / --strip-inlining-info on Android as well (and disables these strip flags for Debug / DebuggerSupport builds), while keeping --strip-il-bodies iOS-like only.

BrzVlad · 2026-07-07T14:18:54Z

-    <PublishReadyToRunCrossgen2ExtraArgs Condition="'$(PublishReadyToRunStripDebugInfo)' != 'false' and $(RuntimeIdentifier.StartsWith('iossimulator-'))">$(PublishReadyToRunCrossgen2ExtraArgs);--strip-debug-info</PublishReadyToRunCrossgen2ExtraArgs>
-    <PublishReadyToRunCrossgen2ExtraArgs Condition="'$(PublishReadyToRunStripDebugInfo)' != 'false' and $(RuntimeIdentifier.StartsWith('tvossimulator-'))">$(PublishReadyToRunCrossgen2ExtraArgs);--strip-debug-info</PublishReadyToRunCrossgen2ExtraArgs>
-    <PublishReadyToRunCrossgen2ExtraArgs Condition="'$(PublishReadyToRunStripDebugInfo)' != 'false' and $(RuntimeIdentifier.StartsWith('maccatalyst-'))">$(PublishReadyToRunCrossgen2ExtraArgs);--strip-debug-info</PublishReadyToRunCrossgen2ExtraArgs>
+    <PublishReadyToRunCrossgen2ExtraArgs Condition="'$(PublishReadyToRunStripInliningInfo)' != 'false' and '$(DebuggerSupport)' != 'true' and '$(Configuration)' != 'Debug' and ('$(_IsIOSLikeRid)' == 'true' or '$(_IsAndroidRid)' == 'true')">$(PublishReadyToRunCrossgen2ExtraArgs);--strip-inlining-info</PublishReadyToRunCrossgen2ExtraArgs>


The properties here get duplicated in the command since they also come from the sdk, once the sdk gets updated. This enables imediate testing but I'm wondering if this code should be removed in the future, once we bump to a preview containing the corresponding sdk changes.

kotlarmilos

LGTM, thanks!

davidnguyen-tech · 2026-07-08T13:32:14Z

+    <PublishReadyToRunCrossgen2ExtraArgs Condition="'$(Optimize)' == 'true' and ('$(_IsIOSLikeRid)' == 'true' or '$(_IsAndroidRid)' == 'true') and ('$(OptimizationPreference)' == 'Size' or '$(OptimizationPreference)' == '')">--Os;$(PublishReadyToRunCrossgen2ExtraArgs)</PublishReadyToRunCrossgen2ExtraArgs>
+    <PublishReadyToRunCrossgen2ExtraArgs Condition="'$(Optimize)' == 'true' and ('$(_IsIOSLikeRid)' == 'true' or '$(_IsAndroidRid)' == 'true') and '$(OptimizationPreference)' == 'Speed'">--Ot;$(PublishReadyToRunCrossgen2ExtraArgs)</PublishReadyToRunCrossgen2ExtraArgs>


Just for my understanding - why did you choose --Os over --Ot as the default optimization preference?

davidnguyen-tech · 2026-07-08T13:51:31Z

Copilot says that this PR is causing some failures on iOS + macCatalyst because of the new --strip-il-bodies

BrzVlad · 2026-07-08T14:12:53Z

/Users/runner/work/1/s/artifacts/bin/Crossgen2Tasks/Release/Microsoft.NET.CrossGen.targets(489,5): error : Error: Object reference not set to an instance of an object. [/Users/runner/work/1/s/src/tests/FunctionalTests/iOS/Simulator/CoreCLR/iOS.CoreCLR.R2R.Test.csproj]
/Users/runner/work/1/s/artifacts/bin/Crossgen2Tasks/Release/Microsoft.NET.CrossGen.targets(489,5): error : System.NullReferenceException: Object reference not set to an instance of an object. [/Users/runner/work/1/s/src/tests/FunctionalTests/iOS/Simulator/CoreCLR/iOS.CoreCLR.R2R.Test.csproj]
/Users/runner/work/1/s/artifacts/bin/Crossgen2Tasks/Release/Microsoft.NET.CrossGen.targets(489,5): error :    at ILCompiler.DependencyAnalysis.ReadyToRun.CopiedMethodILNode.GetData(NodeFactory factory, Boolean relocsOnly) in /_/src/coreclr/tools/aot/ILCompiler.ReadyToRun/Compiler/DependencyAnalysis/ReadyToRun/CopiedMethodILNode.cs:line 59 [/Users/runner/work/1/s/src/tests/FunctionalTests/iOS/Simulator/CoreCLR/iOS.CoreCLR.R2R.Test.csproj]
/Users/runner/work/1/s/artifacts/bin/Crossgen2Tasks/Release/Microsoft.NET.CrossGen.targets(489,5): error :    at ILCompiler.DependencyAnalysis.ReadyToRun.CopiedMethodILDeduplicator.InternKey..ctor(CopiedMethodILNode node, NodeFactory factory) in /_/src/coreclr/tools/aot/ILCompiler.ReadyToRun/Compiler/DependencyAnalysis/ReadyToRun/CopiedMethodILDeduplicator.cs:line 68 [/Users/runner/work/1/s/src/tests/FunctionalTests/iOS/Simulator/CoreCLR/iOS.CoreCLR.R2R.Test.csproj]
/Users/runner/work/1/s/artifacts/bin/Crossgen2Tasks/Release/Microsoft.NET.CrossGen.targets(489,5): error :    at ILCompiler.DependencyAnalysis.ReadyToRun.CopiedMethodILDeduplicator.DeduplicatePass(NodeFactory factory, Dictionary`2 previousSymbolRemapping, Dictionary`2 symbolRemapping) in /_/src/coreclr/tools/aot/ILCompiler.ReadyToRun/Compiler/DependencyAnalysis/ReadyToRun/CopiedMethodILDeduplicator.cs:line 40 [/Users/runner/work/1/s/src/tests/FunctionalTests/iOS/Simulator/CoreCLR/iOS.CoreCLR.R2R.Test.csproj]
/Users/runner/work/1/s/artifacts/bin/Crossgen2Tasks/Release/Microsoft.NET.CrossGen.targets(489,5): error :    at ILCompiler.ObjectDataInterner.EnsureMap(NodeFactory factory) in /_/src/coreclr/tools/Common/Compiler/ObjectDataInterner.cs:line 51 [/Users/runner/work/1/s/src/tests/FunctionalTests/iOS/Simulator/CoreCLR/iOS.CoreCLR.R2R.Test.csproj]
/Users/runner/work/1/s/artifacts/bin/Crossgen2Tasks/Release/Microsoft.NET.CrossGen.targets(489,5): error :    at ILCompiler.ObjectDataInterner.GetDeduplicatedSymbol(NodeFactory factory, ISymbolNode original) in /_/src/coreclr/tools/Common/Compiler/ObjectDataInterner.cs:line 79 [/Users/runner/work/1/s/src/tests/FunctionalTests/iOS/Simulator/CoreCLR/iOS.CoreCLR.R2R.Test.csproj]
/Users/runner/work/1/s/artifacts/bin/Crossgen2Tasks/Release/Microsoft.NET.CrossGen.targets(489,5): error :    at ILCompiler.ObjectWriter.ObjectWriter.EmitObject(Stream outputFileStream, IReadOnlyCollection`1 nodes, IObjectDumper dumper, Logger logger) in /_/src/coreclr/tools/Common/Compiler/ObjectWriter/ObjectWriter.cs:line 383 [/Users/runner/work/1/s/src/tests/FunctionalTests/iOS/Simulator/CoreCLR/iOS.CoreCLR.R2R.Test.csproj]
/Users/runner/work/1/s/artifacts/bin/Crossgen2Tasks/Release/Microsoft.NET.CrossGen.targets(489,5): error :    at ILCompiler.DependencyAnalysis.ReadyToRunObjectWriter.EmitReadyToRunObjects(ReadyToRunContainerFormat format, Logger logger) in /_/src/coreclr/tools/aot/ILCompiler.ReadyToRun/CodeGen/ReadyToRunObjectWriter.cs:line 191 [/Users/runner/work/1/s/src/tests/FunctionalTests/iOS/Simulator/CoreCLR/iOS.CoreCLR.R2R.Test.csproj]
/Users/runner/work/1/s/artifacts/bin/Crossgen2Tasks/Release/Microsoft.NET.CrossGen.targets(489,5): error :    at ILCompiler.DependencyAnalysis.ReadyToRunObjectWriter.EmitObject(String objectFilePath, EcmaModule componentModule, IEnumerable`1 inputFiles, IReadOnlyCollection`1 nodes, NodeFactory factory, Boolean generateMapFile, Boolean generateMapCsvFile, Boolean generatePdbFile, String pdbPath, Boolean generatePerfMapFile, String perfMapPath, Int32 perfMapFormatVersion, Boolean generateProfileFile, CallChainProfile callChainProfile, ReadyToRunContainerFormat format, Int32 customPESectionAlignment, Logger logger) in /_/src/coreclr/tools/aot/ILCompiler.ReadyToRun/CodeGen/ReadyToRunObjectWriter.cs:line 345 [/Users/runner/work/1/s/src/tests/FunctionalTests/iOS/Simulator/CoreCLR/iOS.CoreCLR.R2R.Test.csproj]
/Users/runner/work/1/s/artifacts/bin/Crossgen2Tasks/Release/Microsoft.NET.CrossGen.targets(489,5): error :    at ILCompiler.ReadyToRunCodegenCompilation.Compile(String outputFile) in /_/src/coreclr/tools/aot/ILCompiler.ReadyToRun/Compiler/ReadyToRunCodegenCompilation.cs:line 413 [/Users/runner/work/1/s/src/tests/FunctionalTests/iOS/Simulator/CoreCLR/iOS.CoreCLR.R2R.Test.csproj]
/Users/runner/work/1/s/artifacts/bin/Crossgen2Tasks/Release/Microsoft.NET.CrossGen.targets(489,5): error :    at ILCompiler.Program.RunSingleCompilation(Dictionary`2 inFilePaths, InstructionSetSupport instructionSetSupport, String compositeRootPath, Dictionary`2 unrootedInputFilePaths, HashSet`1 versionBubbleModulesHash, ReadyToRunCompilerContext typeSystemContext, Logger logger) in /_/src/coreclr/tools/aot/crossgen2/Program.cs:line 691 [/Users/runner/work/1/s/src/tests/FunctionalTests/iOS/Simulator/CoreCLR/iOS.CoreCLR.R2R.Test.csproj]
/Users/runner/work/1/s/artifacts/bin/Crossgen2Tasks/Release/Microsoft.NET.CrossGen.targets(489,5): error :    at ILCompiler.Program.Run() in /_/src/coreclr/tools/aot/crossgen2/Program.cs:line 314 [/Users/runner/work/1/s/src/tests/FunctionalTests/iOS/Simulator/CoreCLR/iOS.CoreCLR.R2R.Test.csproj]

@kotlarmilos Any idea about this before I try to reproduce ? Seems weird since this options should be part of P5, so reasonably well tested already

kotlarmilos · 2026-07-08T14:16:55Z

/Users/runner/work/1/s/artifacts/bin/Crossgen2Tasks/Release/Microsoft.NET.CrossGen.targets(489,5): error : Error: Object reference not set to an instance of an object. [/Users/runner/work/1/s/src/tests/FunctionalTests/iOS/Simulator/CoreCLR/iOS.CoreCLR.R2R.Test.csproj]
/Users/runner/work/1/s/artifacts/bin/Crossgen2Tasks/Release/Microsoft.NET.CrossGen.targets(489,5): error : System.NullReferenceException: Object reference not set to an instance of an object. [/Users/runner/work/1/s/src/tests/FunctionalTests/iOS/Simulator/CoreCLR/iOS.CoreCLR.R2R.Test.csproj]
/Users/runner/work/1/s/artifacts/bin/Crossgen2Tasks/Release/Microsoft.NET.CrossGen.targets(489,5): error :    at ILCompiler.DependencyAnalysis.ReadyToRun.CopiedMethodILNode.GetData(NodeFactory factory, Boolean relocsOnly) in /_/src/coreclr/tools/aot/ILCompiler.ReadyToRun/Compiler/DependencyAnalysis/ReadyToRun/CopiedMethodILNode.cs:line 59 [/Users/runner/work/1/s/src/tests/FunctionalTests/iOS/Simulator/CoreCLR/iOS.CoreCLR.R2R.Test.csproj]
/Users/runner/work/1/s/artifacts/bin/Crossgen2Tasks/Release/Microsoft.NET.CrossGen.targets(489,5): error :    at ILCompiler.DependencyAnalysis.ReadyToRun.CopiedMethodILDeduplicator.InternKey..ctor(CopiedMethodILNode node, NodeFactory factory) in /_/src/coreclr/tools/aot/ILCompiler.ReadyToRun/Compiler/DependencyAnalysis/ReadyToRun/CopiedMethodILDeduplicator.cs:line 68 [/Users/runner/work/1/s/src/tests/FunctionalTests/iOS/Simulator/CoreCLR/iOS.CoreCLR.R2R.Test.csproj]
/Users/runner/work/1/s/artifacts/bin/Crossgen2Tasks/Release/Microsoft.NET.CrossGen.targets(489,5): error :    at ILCompiler.DependencyAnalysis.ReadyToRun.CopiedMethodILDeduplicator.DeduplicatePass(NodeFactory factory, Dictionary`2 previousSymbolRemapping, Dictionary`2 symbolRemapping) in /_/src/coreclr/tools/aot/ILCompiler.ReadyToRun/Compiler/DependencyAnalysis/ReadyToRun/CopiedMethodILDeduplicator.cs:line 40 [/Users/runner/work/1/s/src/tests/FunctionalTests/iOS/Simulator/CoreCLR/iOS.CoreCLR.R2R.Test.csproj]
/Users/runner/work/1/s/artifacts/bin/Crossgen2Tasks/Release/Microsoft.NET.CrossGen.targets(489,5): error :    at ILCompiler.ObjectDataInterner.EnsureMap(NodeFactory factory) in /_/src/coreclr/tools/Common/Compiler/ObjectDataInterner.cs:line 51 [/Users/runner/work/1/s/src/tests/FunctionalTests/iOS/Simulator/CoreCLR/iOS.CoreCLR.R2R.Test.csproj]
/Users/runner/work/1/s/artifacts/bin/Crossgen2Tasks/Release/Microsoft.NET.CrossGen.targets(489,5): error :    at ILCompiler.ObjectDataInterner.GetDeduplicatedSymbol(NodeFactory factory, ISymbolNode original) in /_/src/coreclr/tools/Common/Compiler/ObjectDataInterner.cs:line 79 [/Users/runner/work/1/s/src/tests/FunctionalTests/iOS/Simulator/CoreCLR/iOS.CoreCLR.R2R.Test.csproj]
/Users/runner/work/1/s/artifacts/bin/Crossgen2Tasks/Release/Microsoft.NET.CrossGen.targets(489,5): error :    at ILCompiler.ObjectWriter.ObjectWriter.EmitObject(Stream outputFileStream, IReadOnlyCollection`1 nodes, IObjectDumper dumper, Logger logger) in /_/src/coreclr/tools/Common/Compiler/ObjectWriter/ObjectWriter.cs:line 383 [/Users/runner/work/1/s/src/tests/FunctionalTests/iOS/Simulator/CoreCLR/iOS.CoreCLR.R2R.Test.csproj]
/Users/runner/work/1/s/artifacts/bin/Crossgen2Tasks/Release/Microsoft.NET.CrossGen.targets(489,5): error :    at ILCompiler.DependencyAnalysis.ReadyToRunObjectWriter.EmitReadyToRunObjects(ReadyToRunContainerFormat format, Logger logger) in /_/src/coreclr/tools/aot/ILCompiler.ReadyToRun/CodeGen/ReadyToRunObjectWriter.cs:line 191 [/Users/runner/work/1/s/src/tests/FunctionalTests/iOS/Simulator/CoreCLR/iOS.CoreCLR.R2R.Test.csproj]
/Users/runner/work/1/s/artifacts/bin/Crossgen2Tasks/Release/Microsoft.NET.CrossGen.targets(489,5): error :    at ILCompiler.DependencyAnalysis.ReadyToRunObjectWriter.EmitObject(String objectFilePath, EcmaModule componentModule, IEnumerable`1 inputFiles, IReadOnlyCollection`1 nodes, NodeFactory factory, Boolean generateMapFile, Boolean generateMapCsvFile, Boolean generatePdbFile, String pdbPath, Boolean generatePerfMapFile, String perfMapPath, Int32 perfMapFormatVersion, Boolean generateProfileFile, CallChainProfile callChainProfile, ReadyToRunContainerFormat format, Int32 customPESectionAlignment, Logger logger) in /_/src/coreclr/tools/aot/ILCompiler.ReadyToRun/CodeGen/ReadyToRunObjectWriter.cs:line 345 [/Users/runner/work/1/s/src/tests/FunctionalTests/iOS/Simulator/CoreCLR/iOS.CoreCLR.R2R.Test.csproj]
/Users/runner/work/1/s/artifacts/bin/Crossgen2Tasks/Release/Microsoft.NET.CrossGen.targets(489,5): error :    at ILCompiler.ReadyToRunCodegenCompilation.Compile(String outputFile) in /_/src/coreclr/tools/aot/ILCompiler.ReadyToRun/Compiler/ReadyToRunCodegenCompilation.cs:line 413 [/Users/runner/work/1/s/src/tests/FunctionalTests/iOS/Simulator/CoreCLR/iOS.CoreCLR.R2R.Test.csproj]
/Users/runner/work/1/s/artifacts/bin/Crossgen2Tasks/Release/Microsoft.NET.CrossGen.targets(489,5): error :    at ILCompiler.Program.RunSingleCompilation(Dictionary`2 inFilePaths, InstructionSetSupport instructionSetSupport, String compositeRootPath, Dictionary`2 unrootedInputFilePaths, HashSet`1 versionBubbleModulesHash, ReadyToRunCompilerContext typeSystemContext, Logger logger) in /_/src/coreclr/tools/aot/crossgen2/Program.cs:line 691 [/Users/runner/work/1/s/src/tests/FunctionalTests/iOS/Simulator/CoreCLR/iOS.CoreCLR.R2R.Test.csproj]
/Users/runner/work/1/s/artifacts/bin/Crossgen2Tasks/Release/Microsoft.NET.CrossGen.targets(489,5): error :    at ILCompiler.Program.Run() in /_/src/coreclr/tools/aot/crossgen2/Program.cs:line 314 [/Users/runner/work/1/s/src/tests/FunctionalTests/iOS/Simulator/CoreCLR/iOS.CoreCLR.R2R.Test.csproj]

@kotlarmilos Any idea about this before I try to reproduce ? Seems weird since this options should be part of P5, so reasonably well tested already

No, I haven't seen this before. Could it happen if stripping is performed twice over the same assembly?

kotlarmilos · 2026-07-08T14:17:21Z

Copilot says that this PR is causing some failures on iOS + macCatalyst because of the new --strip-il-bodies

This shouldn't be the case, it is already enabled in P5 on Apple mobile

davidnguyen-tech · 2026-07-08T14:23:11Z

I'm trying to reproduce the failures locally, will keep you updated.

davidnguyen-tech · 2026-07-08T20:08:42Z

Note

🤖 This comment was authored by GitHub Copilot (CLI) at the request of the account owner.

Root cause of the ios-arm64 / maccatalyst-arm64 R2R CI failures:

--strip-il-bodies was built to work only in composite R2R mode (all assemblies compiled into a single image). Proof:

Its --help text: "Replace IL method bodies of compiled methods with a throwing stub in composite R2R output assemblies" — Crossgen2RootCommand.cs#L152, added in [crossgen2] Add --strip-il-bodies option for composite R2R #125647 ("Add --strip-il-bodies option for composite R2R").
In the source, the lookup it checks — CompiledMethodDefs — is populated only inside the if (moduleGroup.IsCompositeBuildMode) branch: ReadyToRunCodegenCompilation.cs#L429. Non-composite leaves it null.

But the iOS functional-test R2R build compiles in non-composite mode (per-assembly, --obj-format:pe, no --composite) — confirmed from the failing build's binlog. So the flag's check dereferences the null CompiledMethodDefs and crossgen2 dies with a NullReferenceException (CopiedMethodILNode.cs#L59) → the NETSDK1096 failure.

kotlarmilos · 2026-07-09T09:39:21Z

@davidnguyen-tech Thanks, this is good direction!

--strip-il-bodies was built to work only in composite R2R mode (all assemblies compiled into a single image). Proof:

Correct, this PR adds --strip-il-bodies to the general PublishReadyToRunCrossgen2ExtraArgs, which the RunReadyToRunCompiler task appends to every crossgen2 invocation. The SDK only ever adds it through Crossgen2CompositeExtraCommandLineArgs, gated on PublishReadyToRunComposite == true.

But the iOS functional-test R2R build compiles in non-composite mode (per-assembly, --obj-format:pe, no --composite) — confirmed from the failing build's binlog

This could be a bug in how the functional tests are built where the composite mode isn't set properly. I confirmed the libraries and runtime tests run in composite mode.

BrzVlad · 2026-07-09T09:51:45Z

Tried to reproduce locally but failed. The functional tests are weird: https://github.com/dotnet/runtime/blob/main/src/tests/FunctionalTests/iOS/Simulator/CoreCLR/iOS.CoreCLR.R2R.Test.csproj, they set PublishReadyToRun manually. I suspect adding PublishReadyToRunComposite in this project might fix it as well. Anyhow, for now I just made crossgen2 not trip over strip-il-bodies in non composite mode

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

                    nodeFactoryFlags.StripILBodies = Get(_command.StripILBodies);
+                    if (nodeFactoryFlags.StripILBodies && !composite)
+                    {
+                        throw new Exception(SR.ErrorStripILBodiesRequiresComposite);


Copilot

Copilot's findings

Files reviewed: 3/3 changed files
Comments generated: 2

This also makes the r2r use the size opt (--Os) as a default on mobile. Refactor repeated rid check by using `_IsIOSLikeRid` like we do in the sdk. Disable the strip flags on debug builds, to match the sdk Enable --strip-debug-info and --strip-inlining-info on android release as well. --strip-il-bodies is not enabled because IL should still be needed for tiered jit.

Not supported yet

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

MichalPetryka · 2026-07-13T22:40:49Z

+    <PublishReadyToRunCrossgen2ExtraArgs Condition="'$(PublishReadyToRunStripDebugInfo)' != 'false' and '$(DebuggerSupport)' != 'true' and '$(Configuration)' != 'Debug' and ('$(_IsIOSLikeRid)' == 'true' or '$(_IsAndroidRid)' == 'true')">$(PublishReadyToRunCrossgen2ExtraArgs);--strip-debug-info</PublishReadyToRunCrossgen2ExtraArgs>
+    <PublishReadyToRunCrossgen2ExtraArgs Condition="'$(PublishReadyToRunStripILBodies)' != 'false' and '$(DebuggerSupport)' != 'true' and '$(Configuration)' != 'Debug' and '$(_IsIOSLikeRid)' == 'true'">$(PublishReadyToRunCrossgen2ExtraArgs);--strip-il-bodies</PublishReadyToRunCrossgen2ExtraArgs>
+
+    <PublishReadyToRunCrossgen2ExtraArgs Condition="'$(Optimize)' == 'true' and ('$(_IsIOSLikeRid)' == 'true' or '$(_IsAndroidRid)' == 'true') and ('$(OptimizationPreference)' == 'Size' or '$(OptimizationPreference)' == '')">--Os;$(PublishReadyToRunCrossgen2ExtraArgs)</PublishReadyToRunCrossgen2ExtraArgs>


@MichalStrehovsky Should we add Balanced to differentiate from unset here? Then for mobiles unset would be size but otherwise it'd be Balanced.

That depends on how crossgen wants to document this. Defaulting to size already doesn't match the native AOT behaviors or documentation, so crossgen can do whatever it wants.

The native AOT docs literally say setting this to Size will prefer size at the cost of any other metric (startup, memory, etc.) and the user is supposed to measure whether the compromise is worth it to them.

Copilot AI review requested due to automatic review settings July 7, 2026 14:12

github-actions Bot added the area-crossgen2-coreclr only use for closed issues label Jul 7, 2026

dotnet-policy-service Bot assigned BrzVlad Jul 7, 2026

Copilot started reviewing on behalf of BrzVlad July 7, 2026 14:13 View session

Copilot AI reviewed Jul 7, 2026

View reviewed changes

BrzVlad commented Jul 7, 2026

View reviewed changes

Comment thread src/tasks/Crossgen2Tasks/Microsoft.NET.CrossGen.targets

BrzVlad mentioned this pull request Jul 7, 2026

Make apple mobile targets R2R size optimized by default #130128

Closed

kotlarmilos mentioned this pull request Jul 8, 2026

[Android] Separate --partial with a semicolon in crossgen2 extra args dotnet/maui#36449

Closed

kotlarmilos self-requested a review July 8, 2026 13:02

kotlarmilos approved these changes Jul 8, 2026

View reviewed changes

davidnguyen-tech reviewed Jul 8, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings July 9, 2026 09:49

Copilot started reviewing on behalf of BrzVlad July 9, 2026 09:49 View session

Copilot AI reviewed Jul 9, 2026

View reviewed changes

Comment thread src/tasks/Crossgen2Tasks/Microsoft.NET.CrossGen.targets

Comment thread src/coreclr/tools/aot/crossgen2/Program.cs

jkotas reviewed Jul 9, 2026

View reviewed changes

Comment thread src/coreclr/tools/aot/crossgen2/Program.cs Outdated

Copilot AI review requested due to automatic review settings July 9, 2026 11:10

BrzVlad force-pushed the feature-mobile-r2r-opt branch from 7fd70df to 9fac3a5 Compare July 9, 2026 11:10

Copilot started reviewing on behalf of BrzVlad July 9, 2026 11:11 View session

Copilot AI reviewed Jul 9, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings July 10, 2026 09:12

Copilot started reviewing on behalf of kotlarmilos July 10, 2026 09:12 View session

Copilot AI reviewed Jul 10, 2026

View reviewed changes

Comment thread src/coreclr/tools/aot/crossgen2/Program.cs

Comment thread src/tasks/Crossgen2Tasks/Microsoft.NET.CrossGen.targets

This was referenced Jul 10, 2026

[infra] npm error code ECONNRESET #122671

Open

[ci-scan] Test failure: System.Globalization.Tests.IdnMappingGetUnicodeTests DllNotFoundException 'libSystem.Globalization.Native' on browser-wasm CoreCLR #130479

Open

BrzVlad added 2 commits July 13, 2026 13:29

Throw error on --strip-il-bodies in non-composite mode

40cf589

Not supported yet

Copilot AI review requested due to automatic review settings July 13, 2026 10:48

BrzVlad force-pushed the feature-mobile-r2r-opt branch from 264b1d2 to 40cf589 Compare July 13, 2026 10:48

Copilot started reviewing on behalf of BrzVlad July 13, 2026 10:49 View session

Copilot AI reviewed Jul 13, 2026

View reviewed changes

Comment thread src/tasks/Crossgen2Tasks/Microsoft.NET.CrossGen.targets

Comment thread src/coreclr/tools/aot/crossgen2/Properties/Resources.resx

MichalPetryka reviewed Jul 13, 2026

View reviewed changes

		<PublishReadyToRunCrossgen2ExtraArgs Condition="'$(Optimize)' == 'true' and ('$(_IsIOSLikeRid)' == 'true' or '$(_IsAndroidRid)' == 'true') and ('$(OptimizationPreference)' == 'Size' or '$(OptimizationPreference)' == '')">--Os;$(PublishReadyToRunCrossgen2ExtraArgs)</PublishReadyToRunCrossgen2ExtraArgs>
		<PublishReadyToRunCrossgen2ExtraArgs Condition="'$(Optimize)' == 'true' and ('$(_IsIOSLikeRid)' == 'true' or '$(_IsAndroidRid)' == 'true') and '$(OptimizationPreference)' == 'Speed'">--Ot;$(PublishReadyToRunCrossgen2ExtraArgs)</PublishReadyToRunCrossgen2ExtraArgs>

Uh oh!

Conversation

BrzVlad commented Jul 7, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

BrzVlad Jul 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kotlarmilos left a comment

Choose a reason for hiding this comment

Uh oh!

davidnguyen-tech Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

davidnguyen-tech commented Jul 8, 2026

Uh oh!

BrzVlad commented Jul 8, 2026

Uh oh!

kotlarmilos commented Jul 8, 2026

Uh oh!

kotlarmilos commented Jul 8, 2026

Uh oh!

davidnguyen-tech commented Jul 8, 2026

Uh oh!

davidnguyen-tech commented Jul 8, 2026

Uh oh!

kotlarmilos commented Jul 9, 2026

Uh oh!

BrzVlad commented Jul 9, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

MichalPetryka Jul 13, 2026

Choose a reason for hiding this comment

Uh oh!

MichalStrehovsky Jul 14, 2026

Choose a reason for hiding this comment

Uh oh!

MichalStrehovsky Jul 14, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants