Skip to content

[browser][coreCLR] Re-enable passing libraries tests on browser+CoreCLR #130037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
radekdoulik merged 4 commits into from
Jun 30, 2026
Merged

[browser][coreCLR] Re-enable passing libraries tests on browser+CoreCLR #130037

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
045730d
Re-enable EventSource ActivityTracking tests on browser+CoreCLR
radekdoulik Jun 11, 2026
efe95fa
Re-enable dynamic (DLR) conformance tests on browser+CoreCLR
radekdoulik Jun 11, 2026
e14b7b4
Re-enable Environment.ProcessPath_MatchesExpectedValue on browser+Cor…
radekdoulik Jun 11, 2026
b9ce5c6
Re-enable supported ComVariant marshalling tests on browser+CoreCLR
radekdoulik Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/libraries/System.Diagnostics.Tracing/tests/BasicEventSourceTest/ActivityTracking.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ public void IsSupported()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/129088", typeof(PlatformDetection), nameof(PlatformDetection.IsAndroid), nameof(PlatformDetection.IsMonoRuntime))]
public void StartStopCreatesActivity()
{
Expand All @@ -69,7 +68,6 @@ public void StartStopCreatesActivity()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/129088", typeof(PlatformDetection), nameof(PlatformDetection.IsAndroid), nameof(PlatformDetection.IsMonoRuntime))]
public async Task ActivityFlowsAsync()
{
Expand Down Expand Up @@ -119,7 +117,6 @@ private async Task YieldTwoActivitiesDeep(ActivityEventSource es)
// the future we might decide it wasn't even desirable to begin with.
// Compare with SetCurrentActivityIdAfterEventDoesNotFlowAsync below.
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/129088", typeof(PlatformDetection), nameof(PlatformDetection.IsAndroid), nameof(PlatformDetection.IsMonoRuntime))]
public async Task SetCurrentActivityIdBeforeEventFlowsAsync()
{
Expand All @@ -146,7 +143,6 @@ public async Task SetCurrentActivityIdBeforeEventFlowsAsync()
// the future we might decide it wasn't even desirable to begin with.
// Compare with SetCurrentActivityIdBeforeEventFlowsAsync above.
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/129088", typeof(PlatformDetection), nameof(PlatformDetection.IsAndroid), nameof(PlatformDetection.IsMonoRuntime))]
public async Task SetCurrentActivityIdAfterEventDoesNotFlowAsync()
{
Expand Down
3 changes: 0 additions & 3 deletions ...ime.InteropServices.UnitTests/System/Runtime/InteropServices/ComVariantMarshallerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,13 @@ namespace System.Runtime.InteropServices.Tests
public partial class ComVariantMarshallerTests
{
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public void Null_Marshals_To_Empty()
{
Assert.Equal(VarEnum.VT_EMPTY, ComVariantMarshaller.ConvertToUnmanaged(null).VarType);
Assert.Null(ComVariantMarshaller.ConvertToManaged(default));
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public void DBNull_Marshals_To_Null()
{
Assert.Equal(VarEnum.VT_NULL, ComVariantMarshaller.ConvertToUnmanaged(DBNull.Value).VarType);
Expand Down Expand Up @@ -267,7 +265,6 @@ public void Decimal_Marshals_To_DECIMAL(decimal value)
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public void Date_Marshals_To_DATE()
{
// OLE dates do not have time zones and do not support sub-millisecond precision.
Expand Down
2 changes: 0 additions & 2 deletions ...ystem.Runtime.InteropServices.UnitTests/System/Runtime/InteropServices/ComVariantTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,14 +143,12 @@ public void VariantBoolFalse()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public void VTVariantNotSupported()
{
Assert.Throws<ArgumentException>("vt", () => ComVariant.CreateRaw(VarEnum.VT_VARIANT, 1));
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsBuiltInComEnabled))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public void Unknown_NotSupported()
{
UnknownWrapper wrapper = new(new TestObject());
Expand Down
2 changes: 0 additions & 2 deletions ...tem.Dynamic.Runtime.Tests/Dynamic.Context/Conformance.dynamic.context.indexer.regclass.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1007,7 +1007,6 @@ namespace ManagedTests.DynamicCSharp.Conformance.dynamic.context.indexer.regclas
public class Test
{
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public static void DynamicCSharpRunTest()
{
Assert.Equal(0, MainMethod());
Expand Down Expand Up @@ -2296,7 +2295,6 @@ namespace ManagedTests.DynamicCSharp.Conformance.dynamic.context.indexer.regclas
public class Test
{
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public static void DynamicCSharpRunTest()
{
Assert.Equal(0, MainMethod());
Expand Down
2 changes: 0 additions & 2 deletions ...ic.Runtime.Tests/Dynamic.Context/Conformance.dynamic.context.method.genmethod.regclass.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,6 @@ namespace ManagedTests.DynamicCSharp.Conformance.dynamic.context.method.genmetho
public class Test
{
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public static void DynamicCSharpRunTest()
{
Assert.Equal(0, MainMethod());
Expand Down Expand Up @@ -976,7 +975,6 @@ namespace ManagedTests.DynamicCSharp.Conformance.dynamic.context.method.genmetho
public class Test
{
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public static void DynamicCSharpRunTest()
{
Assert.Equal(0, MainMethod());
Expand Down
4 changes: 0 additions & 4 deletions ...em.Dynamic.Runtime.Tests/Dynamic.Context/Conformance.dynamic.context.operator.regclass.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -680,7 +680,6 @@ namespace ManagedTests.DynamicCSharp.Conformance.dynamic.context.operate.regclas
public class Test
{
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public static void DynamicCSharpRunTest()
{
Assert.Equal(0, MainMethod());
Expand Down Expand Up @@ -719,7 +718,6 @@ namespace ManagedTests.DynamicCSharp.Conformance.dynamic.context.operate.regclas
public class Test
{
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public static void DynamicCSharpRunTest()
{
Assert.Equal(0, MainMethod());
Expand Down Expand Up @@ -1843,7 +1841,6 @@ namespace ManagedTests.DynamicCSharp.Conformance.dynamic.context.operate.regclas
public class Test
{
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public static void DynamicCSharpRunTest()
{
Assert.Equal(0, MainMethod());
Expand Down Expand Up @@ -3497,7 +3494,6 @@ namespace ManagedTests.DynamicCSharp.Conformance.dynamic.context.operate.regclas
public class Test
{
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public static void DynamicCSharpRunTest()
{
Assert.Equal(0, MainMethod());
Expand Down
1 change: 0 additions & 1 deletion ...ntime.Tests/Dynamic.Context/Conformance.dynamic.context.property.autoproperty.regclass.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,6 @@ namespace ManagedTests.DynamicCSharp.Conformance.dynamic.context.property.autopr
public class Test
{
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
public static void DynamicCSharpRunTest()
{
Assert.Equal(0, MainMethod());
Expand Down
1 change: 0 additions & 1 deletion ...libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/EnvironmentTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,6 @@ public void ProcessPath_Idempotent()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
[SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.Android, "Throws PNSE")]
public void ProcessPath_MatchesExpectedValue()
{
Expand Down
Loading