Add HttpMethod.Query to static method test data#129790
Open
NicoAvanzDev wants to merge 5 commits into
Open
Conversation
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/ncl |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the HttpMethodTest functional tests to include the HttpMethod.Query singleton in the shared static-method test data used by the hash-code theory, improving coverage consistency for built-in HttpMethod instances.
Changes:
- Add
HttpMethod.Queryto theStaticHttpMethodstest data set used by[MemberData]. - Update the static-method list formatting to accommodate the new entry.
Comment on lines
+21
to
+25
| new object[] { HttpMethod.Delete }, | ||
| new object[] { HttpMethod.Head }, | ||
| new object[] { HttpMethod.Options }, | ||
| new object[] { HttpMethod.Trace } | ||
| new object[] { HttpMethod.Trace }, | ||
| new object[] { HttpMethod.Query } |
Member
There was a problem hiding this comment.
This comment looks right.
If we're already making changes here, mind making StaticHttpMethods a List<HttpMethod> instead, then using it in all tests in this file?
There's no point listing out the same list 3 times like is done currently, and the AddStaticHttpMethods helper doesn't make sense either.
This was referenced Jun 24, 2026
Replace separate MemberData lists with a single canonical StaticHttpMethods List<HttpMethod> containing all known HTTP methods (Connect, Delete, Get, Head, Options, Patch, Post, Put, Query, Trace). Convert GetHashCode_StaticMethods and Parse_KnownMethod tests from Theory with MemberData to Fact with foreach loops over StaticHttpMethods. Remove the Parse_UsesKnownInstances_MemberData helper and AddStaticHttpMethods static initializer — the list is now declared directly as a field. This eliminates the duplication of having the static methods list defined in three different places.
…vanzDev/runtime into httpmethod-query-test-data
Contributor
Author
|
@dotnet-policy-service agree |
Comment on lines
+114
to
116
| [Fact] | ||
| public void GetHashCode_StaticMethods_SameAsStringToUpperInvariantHashCode() | ||
| { |
Comment on lines
+152
to
154
| [Fact] | ||
| public void Parse_KnownMethod_UsesKnownInstances() | ||
| { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing