Check for ComInterop case for async variants in crossgen2#129747
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates crossgen2’s JIT interface token/method handling to avoid resolving async variants in cases where no callable runtime async entrypoint will be generated (notably for COM-imported methods), addressing an async-variant resolution crash/assert scenario.
Changes:
- Introduces a shared eligibility check (
HasCallableAsyncVariant) for deciding whether an async variant can be used. - Uses the shared check when selecting the “other variant” in
getAsyncOtherVariant. - Uses the shared check when resolving
CORINFO_TOKENKIND_Awaittokens to an async-variant method (or returning null to force fallback resolution).
Member
Author
|
I suppose it means that adding
|
This was referenced Jun 23, 2026
Open
Member
Author
|
PTAL @AaronRobinsonMSFT I'll open a follow up issue about handling the potential versioning problem highlighted above. This fix should at least get outerloop clean. |
AaronRobinsonMSFT
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This check was added in the VM, but a similar check must be added in crossgen2 to avoid generating calls to async variants of ComImport methods in crossgen2.
Fix #129739