Update arm32 managed code unwinder#129638
Conversation
This change brings the arm32 managed code unwinder to the most up to date state from Windows source.
|
Tagging subscribers to this area: @agocke |
|
/azp run runtime-coreclr libraries-jitstress |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
We have managed clone of the unwinder at https://github.com/dotnet/runtime/blob/main/src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StackWalk/Context/ARM/ARMUnwinder.cs that should be updated to match. It can be separate PR as long as there is tracking issue. cc @max-charlamb |
|
The tests on linux arm32 are still failing with the assert from #128590. It does not appear fixed. |
| #define MSFT_OP_TRAP_FRAME_OLD 0 | ||
| #define MSFT_OP_MACHINE_FRAME 1 | ||
| #define MSFT_OP_CONTEXT 2 | ||
| #define MSFT_OP_TRAP_FRAME 3 | ||
| #define MSFT_OP_REDZONE_FRAME 4 | ||
|
|
There was a problem hiding this comment.
| #define MSFT_OP_TRAP_FRAME_OLD 0 | |
| #define MSFT_OP_MACHINE_FRAME 1 | |
| #define MSFT_OP_CONTEXT 2 | |
| #define MSFT_OP_TRAP_FRAME 3 | |
| #define MSFT_OP_REDZONE_FRAME 4 |
We should never encounter these opcodes and some of the code to handle them is ifdefed out below. Delete them?
| --*/ | ||
|
|
||
| { | ||
| ULONG Fpscr; |
There was a problem hiding this comment.
I think it would look better to delete the whole body of this method in our copy. It is going to help with cdac clone
This change brings the arm32 managed code unwinder to the most up to
date state from Windows source.
Close #128590