[clr-ios] Disable Microsoft.Extensions.DependencyInjection.ExternalContainers.Tests on Apple mobile#129514
Open
kotlarmilos wants to merge 2 commits into
Open
Conversation
…ntainers.Tests on Apple mobile Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the libraries test traversal exclusions to skip Microsoft.Extensions.DependencyInjection.ExternalContainers.Tests under certain AOT/Helix configurations, aiming to avoid Apple-mobile/AOT test runs that end up executing zero tests.
Changes:
- Add
Microsoft.Extensions.DependencyInjection.ExternalContainers.Tests.csprojto theProjectExclusionslist under the existing AOT/Apple-mobile Helix exclusion ItemGroup.
Show a summary per file
| File | Description |
|---|---|
| src/libraries/tests.proj | Adds an exclusion entry for the ExternalContainers DI test project in an AOT/Apple-mobile Helix-related exclusion group. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
/azp run runtime-extra-platforms |
Contributor
|
Tagging subscribers to 'os-ios': @vitek-karas, @kotlarmilos, @steveisok, @akoeplinger |
|
Azure Pipelines successfully started running 1 pipeline(s). |
matouskozak
approved these changes
Jun 17, 2026
| <ItemGroup Condition="('$(TargetOS)' == 'iossimulator' or '$(TargetOS)' == 'tvossimulator' or '$(TargetOS)' == 'maccatalyst') and '$(RuntimeFlavor)' == 'CoreCLR' and '$(UseNativeAOTRuntime)' != 'true'"> | ||
| <ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Reflection.Emit\tests\System.Reflection.Emit.Tests.csproj" /> | ||
| <ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Reflection.Emit.ILGeneration\tests\System.Reflection.Emit.ILGeneration.Tests.csproj" /> | ||
| <ProjectExclusions Include="$(MSBuildThisFileDirectory)Microsoft.Extensions.DependencyInjection\tests\DI.External.Tests\Microsoft.Extensions.DependencyInjection.ExternalContainers.Tests.csproj" /> |
Member
There was a problem hiding this comment.
Would it make sense to run legs without aggressive trimming to get coverage over the areas and have potentially more stable runs?
Member
Author
There was a problem hiding this comment.
Good idea, I think we had aggressive trimming disabled on rolling builds. Let's create a tracking issue
This was referenced Jun 17, 2026
Open
This was referenced Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the aggressively-trimmed Apple-mobile/AOT Helix legs (e.g. iossimulator-arm64 CoreCLR),
Microsoft.Extensions.DependencyInjection.ExternalContainers.Testsdiscovers zero test cases because aggressive trimming strips the reflection-heavy third-party DI containers, so XHarness reports the run as a crash (Tests run: 0); this excludes the project from those configurations alongside its already-excluded siblingDI.Tests.Fixes #129359