Skip to content

Fix GVM dispatch for covariant-return async methods (closes #127197) #129481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Fix GVM dispatch for covariant-return async methods (closes #127197) #129481

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
383767e
Initial plan
Copilot Jun 16, 2026
e7083d2
Fix GVM dispatch for async covariant-return methods (closes #127197)
Copilot Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/coreclr/vm/method.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1986,12 +1986,18 @@ MethodDesc* MethodDesc::ResolveGenericVirtualMethod(OBJECTREF *orThis)
pTargetMDBeforeGenericMethodArgs->GetExactClassInstantiation(TypeHandle(pObjMT))).GetMethodTable();
}

// Pass the async variant lookup kind of the target method so that FindOrCreateAssociatedMethodDesc
// creates the correctly-typed instantiated method descriptor (regular async variant, return-dropping
// thunk, or ordinary method). Without this, a resolved async-variant or RDT target would be
// misidentified as an ordinary method and GetParallelMethodDesc would return the primary thunk
// instead, causing infinite virtual dispatch recursion for covariant-return async GVMs.
RETURN(MethodDesc::FindOrCreateAssociatedMethodDesc(
pTargetMDBeforeGenericMethodArgs,
pTargetMT,
(pTargetMT->IsValueType()), /* get unboxing entry point if a struct*/
pStaticMD->GetMethodInstantiation(),
FALSE /* no allowInstParam */ ));
FALSE /* no allowInstParam */,
pTargetMDBeforeGenericMethodArgs->GetAsyncVariantLookup()));
}

PCODE MethodDesc::GetSingleCallableAddrOfCode()
Expand Down
Loading