[automated] Merge branch 'release/8.0' => 'release/8.0-staging'#129440
Open
github-actions[bot] wants to merge 4 commits into
Open
[automated] Merge branch 'release/8.0' => 'release/8.0-staging'#129440github-actions[bot] wants to merge 4 commits into
github-actions[bot] wants to merge 4 commits into
Conversation
…e/release/8.0-staging-to-release/8.0
Merges `release/8.0-staging` into `release/8.0`. This is a routine forward-merge of the staging branch into the release branch. The merge was performed with no conflicts. > [!NOTE] > This pull request was generated with the assistance of GitHub Copilot.
…129049) > [!NOTE] > This pull request was authored with the assistance of GitHub Copilot. ## Problem Several scheduled outerloop pipelines (the `outerloop.yml` family: `runtime-libraries-coreclr outerloop` and its `-windows`/`-linux`/`-osx` variants) use an `always: false` scheduled trigger. With `always: false`, AzDO only starts a new scheduled run if the source changed **since the last _successful_ scheduled run**. Because the repo has many flaky outerloop tests, the Helix test work items virtually always have at least one failure, which fails the "Send to Helix" step and therefore the whole build. The build never reaches a `succeeded` state, so AzDO re-queues **the same, unchanged commit** day after day, submitting more and more Helix work for no benefit. (Empirically confirmed: a single commit was re-run and failed for 19 consecutive days; once a sibling definition produced a genuinely successful run, the same-SHA re-queue stopped.) ## Why `continueOnError` is not enough `continueOnError: true` only downgrades the build to `partiallySucceeded`, which AzDO's `always: false` scheduler still does **not** treat as successful — so the same commit keeps getting re-queued. The Helix step must end **fully successful** (exit 0). ## Fix Make the "Send to Helix" step actually succeed on scheduled runs by disabling the two Arcade `Microsoft.DotNet.Helix.Sdk` properties that fail the build (both default to `true`): - **`FailOnWorkItemFailure`** — `CheckHelixJobStatus` errors when a work item exits non-zero. - **`FailOnTestFailure`** — `CheckAzurePipelinesTestResults` errors when any published test failed. Setting both to `false` lets the msbuild step exit 0, producing a fully `succeeded` build. Failed tests are still published and visible in the test results tab; AzDO does not auto-degrade a build to `partiallySucceeded` just because a published test run contains failures — only a failing task would. ### Changes - **`eng/pipelines/libraries/helix.yml`**: Added a `failOnTestFailures` parameter (default `true`, preserving today's behavior) wired to `/p:FailOnWorkItemFailure` and `/p:FailOnTestFailure` on the Send to Helix msbuild invocation. - **`eng/pipelines/libraries/outerloop.yml`**: Passes `failOnTestFailures: false` **only on scheduled runs** (`Build.Reason == 'Schedule'`) for all three matrix legs (Release, Debug, NET48). ## Behavior preservation The new parameter defaults to `true`, so all other `helix.yml` callers are unaffected (none set `WaitForWorkItemCompletion` or these properties on this path, so they already resolve to `true`). Only scheduled outerloop runs change behavior. PR / rolling / manual outerloop runs continue to fail on Helix failures exactly as before. Build/compile breaks still fail scheduled runs (this only affects the Helix step). ## Tradeoff On scheduled runs, `FailOnWorkItemFailure=false` also masks work-item crashes/timeouts/infra failures, not just test-assertion failures. This is an accepted tradeoff for the goal of stopping the wasteful daily re-queue of unchanged commits; results remain visible in the Helix/test reporting. --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Jun 18, 2026
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I detected changes in the release/8.0 branch which have not been merged yet to release/8.0-staging. I'm a robot and am configured to help you automatically keep release/8.0-staging up to date, so I've opened this PR.
This PR merges commits made on release/8.0 by the following committers:
Instructions for merging from UI
This PR will not be auto-merged. When pull request checks pass, complete this PR by creating a merge commit, not a squash or rebase commit.
If this repo does not allow creating merge commits from the GitHub UI, use command line instructions.
Instructions for merging via command line
Run these commands to merge this pull request from the command line.
or if you are using SSH
After PR checks are complete push the branch
Instructions for resolving conflicts
Instructions for updating this pull request
Contributors to this repo have permission update this pull request by pushing to the branch 'merge/release/8.0-to-release/8.0-staging'. This can be done to resolve conflicts or make other changes to this pull request before it is merged.
The provided examples assume that the remote is named 'origin'. If you have a different remote name, please replace 'origin' with the name of your remote.
or if you are using SSH
Contact .NET Core Engineering (dotnet/dnceng) if you have questions or issues.
Also, if this PR was generated incorrectly, help us fix it. See https://github.com/dotnet/arcade/blob/main/.github/workflows/scripts/inter-branch-merge.ps1.