Fix OOM message in Native AOT#129256
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves NativeAOT fail-fast diagnostics for out-of-memory scenarios by ensuring stderr contains a reliable OOM token even when Exception.ToString() cannot be produced (e.g., due to OOM/initialization constraints), which unblocks the baseservices/exceptions/OutOfMemoryException test expectation.
Changes:
- In
RuntimeExceptionHelpers.FailFast, when printingexception.ToString()throws, special-caseOutOfMemoryExceptionto emit the allocation-free literal"Out of memory."instead of attempting to print the exception type name. - Update the nearby comment to reflect the simpler fallback behavior.
Member
Author
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jun 11, 2026
Open
Member
Author
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
MichalStrehovsky
approved these changes
Jun 17, 2026
Member
Author
|
/ba-g timeouts only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fall back to a string literal when process finishes with an out of memory exception.
Fixes #129209.