Merged
Conversation
Contributor
Author
|
In my PR #679 I attempted to improve the dumping of GC kills (this is where we spill all GC refs across pinvoke calls), but instead broke them. This is actually an improvement over what I'd done in my EHWriteThru branch, and then incorrectly extracted in #679. It will now print something like the following in the LSRA allocation table: If there are no GC refs live in registers, it will print this: And if there are multiple it will look something like this: Both @briansull and I ran into the |
Contributor
Author
|
@dotnet/jit-contrib PTAL |
BruceForstall
approved these changes
Jan 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.