Skip to content

Fix format pre-commit hook #128649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akoeplinger merged 4 commits into from
Jun 2, 2026
Merged

Fix format pre-commit hook #128649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1f81dc6
Fix format pre-commit hook
am11 May 27, 2026
635ce53
Update code-formatting-tools.md
am11 May 27, 2026
0aa8479
.
am11 May 27, 2026
03873ce
Apply suggestion from @akoeplinger
am11 Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion docs/coding-guidelines/code-formatting-tools.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,8 @@ The following code block can be used as the contents of the `pre-commit` file to

```sh
#!/bin/sh
./eng/formatting/format.sh

./eng/formatting/format.sh
```

Make sure the file is executable (`chmod +x .git/hooks/pre-commit`). If `git config core.hooksPath` points elsewhere, set it with `git config core.hooksPath .git/hooks`.
5 changes: 3 additions & 2 deletions eng/formatting/format.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#!/bin/sh

LC_ALL=C

# Select files to format
NATIVE_FILES=$(git diff --cached --name-only --diff-filter=ACM "*.h" "*.hpp" "*.c" "*.cpp" "*.inl" | sed 's| |\\ |g')
MANAGED_FILES=$(git diff --cached --name-only --diff-filter=ACM "*.cs" "*.vb" | sed 's| |\\ |g')
Expand All @@ -9,15 +10,15 @@ exec 1>&2

if [ -n "$NATIVE_FILES" ]; then
# Format all selected files
echo "$NATIVE_FILES" | cat | xargs | sed -e 's/ /,/g' | xargs "./artifacts/tools/clang-format" -style=file -i
Comment thread
akoeplinger marked this conversation as resolved.
echo "$NATIVE_FILES" | xargs "./artifacts/tools/clang-format" -style=file -i

# Add back the modified files to staging
echo "$NATIVE_FILES" | xargs git add
fi

if [ -n "$MANAGED_FILES" ]; then
# Format all selected files
echo "$MANAGED_FILES" | cat | xargs | sed -e 's/ /,/g' | dotnet format whitespace --include - --folder
echo "$MANAGED_FILES" | dotnet format whitespace --include - --folder

# Add back the modified files to staging
echo "$MANAGED_FILES" | xargs git add
Expand Down
Loading