Fix clobbering of RhpInterfaceDispatchSlow arguments on riscv64#128374
Merged
Conversation
The tail pseudo-instruction is expanded by the assembler into
auipc t1, ...
jalr x0, t1, ...
thus the parameter of the thunk's target gets corrupted. Avoid that
by using a different scratch register to calculate the address of
RhpUniversalTransitionTailCall.
Signed-off-by: Maxim Menshikov <maksim.menshikov@nethermind.io>
Contributor
|
Tagging subscribers to this area: @agocke |
filipnavara
approved these changes
May 19, 2026
This was referenced May 19, 2026
Open
Member
|
@jkotas, PTAL. |
jkotas
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tail pseudo-instruction is expanded by the assembler into
auipc t1, ...
jalr x0, t1, ...
thus the parameter of the thunk's target gets corrupted. Avoid that by using a different scratch register to calculate the address of RhpUniversalTransitionTailCall.