Add MemoryExtensions.Min/Max#128306
Merged
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-memory |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds Min and Max extension methods on ReadOnlySpan<T> (with optional IComparer<T>), mirroring LINQ's Enumerable.Min/Max semantics for spans. Includes ref assembly updates and tests.
Changes:
- New
Min/MaxReadOnlySpan extension methods with empty-span and null-element handling. - Reference assembly exposes the four new API overloads.
- New test file covering empty, all-null, mixed-null, default comparer, and custom comparer scenarios.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| src/libraries/System.Private.CoreLib/src/System/MemoryExtensions.cs | Implements Min/Max with a generic comparer fast path and null-skipping inner core. |
| src/libraries/System.Memory/ref/System.Memory.cs | Adds public surface for the four new overloads. |
| src/libraries/System.Memory/tests/System.Memory.Tests.csproj | Includes the new test file. |
| src/libraries/System.Memory/tests/ReadOnlySpan/MinMax.cs | Tests for empty/null/normal/custom-comparer behaviors. |
Member
|
Enumerable's Min/Max already have vectorized logic implementing this. We should move that logic into these new methods, then switch LINQ to call them instead |
This was referenced May 21, 2026
MihaZupan
reviewed
Jun 23, 2026
MihaZupan
approved these changes
Jun 23, 2026
This was referenced Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds new
MinandMaxextension methods forReadOnlySpan<T>to theSystem.Memorylibrary, allowing users to efficiently find the minimum and maximum values in a span, optionally using a custom comparer. Comprehensive unit tests are included to verify correct behavior for various data types and edge cases.New
MinandMaxmethods forReadOnlySpan<T>:Min<T>andMax<T>extension methods toMemoryExtensionsforReadOnlySpan<T>, supporting both default and custom comparers, and handling nullable and reference types gracefully. These methods throw an exception on empty spans of non-nullable value types and returnnullfor empty spans of reference or nullable types. [1] [2]Unit tests:
ReadOnlySpan/MinMax.csto cover empty spans, all-null values, custom comparers, and typical scenarios for both value and reference types.System.Memory.Tests.csprojto ensure the tests are run as part of the test suite.Fixes #127083