Fix NoopLimiter disposal in DefaultPartitionedRateLimiter Heartbeat#127582

Open

Copilot wants to merge 19 commits into

mainfrom

copilot/fix-noop-limiter-disposal

Commits on Jun 17, 2026

Track per-partition last-access tick so NoopLimiter is evicted by Heartbeat

Copilot
and
VSadov
committed
Address review: remove redundant timestamp write, use Interlocked for atomic 64-bit access

Copilot
and
VSadov
committed
Clarify comment explaining why first-access has no eviction window

Copilot
and
VSadov
committed
Use Volatile.Read/Write instead of Interlocked for LastAccessTimestamp

Copilot
and
VSadov
committed
Add RateLimiterHelper.GetElapsedTime(long) overload to avoid GetValueOrDefault

Copilot
and
VSadov
committed
Restrict idle eviction fallback to NoopLimiter

Copilot
and
VSadov
committed
Apply remaining changes

Copilot
and
VSadov
committed
Merge main + fix build after Utils.RunTimerFunc signature change

Copilot
and
VSadov
committed
Remove unrelated scratch files accidentally committed earlier

Copilot
and
VSadov
committed
Potential fix for pull request finding

VSadov
and
Copilot
committed
Potential fix for pull request finding

VSadov
and
Copilot
committed
Encapsulate limiter entry timestamp

Copilot
and
VSadov
committed
Centralize reflected type names in rate limiting tests

Copilot
and
VSadov
committed
Add Assert.True(limiterType.IsInstanceOfType(limiter)) before GetValue in GetLazyLimiterEntry

Copilot
and
VSadov
committed
Add explicit null check for nullable TimeSpan comparison in Heartbeat

Copilot
and
VSadov
committed
Clarify RateLimiting test comment

Copilot
and
VSadov
committed
Use is-pattern for nullable TimeSpan comparison in Heartbeat eviction

Copilot
and
VSadov
committed
Potential fix for pull request finding

VSadov
and
Copilot
authored

Commits on Jun 18, 2026

Potential fix for pull request finding

VSadov
and
Copilot
authored

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix NoopLimiter disposal in DefaultPartitionedRateLimiter Heartbeat#127582

Fix NoopLimiter disposal in DefaultPartitionedRateLimiter Heartbeat#127582
Copilot wants to merge 19 commits into
mainfrom
copilot/fix-noop-limiter-disposal

Commits on Jun 17, 2026

Track per-partition last-access tick so NoopLimiter is evicted by Heartbeat

Address review: remove redundant timestamp write, use Interlocked for atomic 64-bit access

Clarify comment explaining why first-access has no eviction window

Use Volatile.Read/Write instead of Interlocked for LastAccessTimestamp

Add RateLimiterHelper.GetElapsedTime(long) overload to avoid GetValueOrDefault

Restrict idle eviction fallback to NoopLimiter

Apply remaining changes

Merge main + fix build after Utils.RunTimerFunc signature change

Remove unrelated scratch files accidentally committed earlier

Potential fix for pull request finding

Potential fix for pull request finding

Encapsulate limiter entry timestamp

Centralize reflected type names in rate limiting tests

Add Assert.True(limiterType.IsInstanceOfType(limiter)) before GetValue in GetLazyLimiterEntry

Add explicit null check for nullable TimeSpan comparison in Heartbeat

Clarify RateLimiting test comment

Use is-pattern for nullable TimeSpan comparison in Heartbeat eviction

Potential fix for pull request finding

Commits on Jun 18, 2026

Potential fix for pull request finding