ReadPipesToBuffers: remove unneeded DangerousAddRef/DangerousRelease from ReadPipesToBuffers.#127553
Closed
tmds wants to merge 1 commit into
Closed
ReadPipesToBuffers: remove unneeded DangerousAddRef/DangerousRelease from ReadPipesToBuffers.#127553tmds wants to merge 1 commit into
tmds wants to merge 1 commit into
Conversation
…from ReadPipesToBuffers.
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-diagnostics-process |
jkotas
reviewed
Apr 29, 2026
| outputHandle.DangerousAddRef(ref outputRefAdded); | ||
| errorHandle.DangerousAddRef(ref errorRefAdded); | ||
|
|
||
| ReadPipes(outputHandle, errorHandle, timeoutMs, |
Member
There was a problem hiding this comment.
ReadPipes on Unix does DangerousGetHandle . What is going to make that safe when this DangerousAddRef is deleted?
Member
Author
There was a problem hiding this comment.
You're right. I thought the add ref was to avoid the non-owning handle that was added in #126807 to lose ownership. It is also used for other things.
Member
Author
|
Closing. The code depends on the DangerousAddRef for polling the fds. |
This was referenced Apr 29, 2026
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per https://github.com/dotnet/runtime/pull/126807/changes#r3085172163.
@adamsitnik @jkotas ptal.