Skip to content

Re-enable OSX runtime-diagnostics legs#127492

Merged
rcj1 merged 6 commits into
dotnet:mainfrom
rcj1:reenable-osx
May 1, 2026
Merged

Re-enable OSX runtime-diagnostics legs#127492
rcj1 merged 6 commits into
dotnet:mainfrom
rcj1:reenable-osx

Conversation

@rcj1

@rcj1 rcj1 commented Apr 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #126435

Copilot AI review requested due to automatic review settings April 28, 2026 04:24
@dotnet-policy-service

dotnet-policy-service Bot commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

Copilot AI reviewed Apr 28, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR re-enables macOS coverage for the runtime-diagnostics pipeline’s cDAC dump-test legs by adding osx_arm64 and osx_x64 back into the default cdacDumpPlatforms list.

Changes:

  • Add osx_arm64 and osx_x64 to the default cDAC dump-test platform matrix.

Comment thread eng/pipelines/runtime-diagnostics.yml
@build-analysis build-analysis Bot mentioned this pull request Apr 28, 2026
Closed
Copilot AI review requested due to automatic review settings April 28, 2026 19:27
Copilot AI reviewed Apr 28, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment thread src/native/managed/cdac/tests/DumpTests/cdac-dump-xplat-test-helix.proj Outdated
@rcj1
Apply suggestion from @Copilot
1dd0fbd 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 28, 2026 21:16
Copilot AI reviewed Apr 28, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

This was referenced Apr 29, 2026
Open
Open
Open
Closed
@build-analysis build-analysis Bot mentioned this pull request Apr 29, 2026
Open
@rcj1 rcj1 marked this pull request as ready for review April 29, 2026 17:45
Copilot AI review requested due to automatic review settings April 29, 2026 17:45
Copilot AI reviewed Apr 29, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@build-analysis build-analysis Bot mentioned this pull request May 1, 2026
Open
Copilot AI review requested due to automatic review settings May 1, 2026 14:00
Copilot AI reviewed May 1, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Comment thread src/native/managed/cdac/tests/DumpTests/ClrMdDumpHost.cs
Comment thread ...ged/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeTypeSystem_1.cs Outdated
Comment thread ...ged/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeTypeSystem_1.cs Outdated
@build-analysis build-analysis Bot mentioned this pull request May 1, 2026
Open
Copilot AI review requested due to automatic review settings May 1, 2026 18:56
@rcj1

rcj1 commented May 1, 2026

Copy link
Copy Markdown
Contributor Author

/ba-g already ran ci

1 similar comment
@rcj1

rcj1 commented May 1, 2026

Copy link
Copy Markdown
Contributor Author

/ba-g already ran ci

@rcj1 rcj1 merged commit 3c0181d into dotnet:main May 1, 2026
159 of 190 checks passed
@rcj1 rcj1 deleted the reenable-osx branch May 1, 2026 18:58
@rcj1 rcj1 removed the request for review from Copilot May 1, 2026 19:18
This was referenced May 1, 2026
Open
Open
Open
Open
@dotnet-maestro dotnet-maestro Bot mentioned this pull request May 2, 2026
Merged
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@hoyosjs hoyosjs hoyosjs approved these changes

Assignees

@rcj1 rcj1

Labels

area-Diagnostics-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cdac dump tests should disable system dump generation

3 participants

@rcj1 @hoyosjs