Skip to content

Fix ArrayValue.ToString separators#126202

Merged
MichalStrehovsky merged 1 commit into
dotnet:mainfrom
larkliy:fix-ilc-tostring
Mar 31, 2026
Merged

Fix ArrayValue.ToString separators#126202
MichalStrehovsky merged 1 commit into
dotnet:mainfrom
larkliy:fix-ilc-tostring

Conversation

@larkliy

@larkliy larkliy commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

Corrects comma placement logic in ArrayValue.ToString() to properly separate elements and nested values.

@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label Mar 27, 2026
Comment thread src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/Dataflow/ArrayValue.cs Outdated
Comment thread src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/Dataflow/ArrayValue.cs Outdated
@larkliy larkliy force-pushed the fix-ilc-tostring branch 2 times, most recently from 291e578 to da03b79 Compare March 27, 2026 14:27
@larkliy

larkliy commented Mar 27, 2026

Copy link
Copy Markdown
Contributor Author

@dotnet-policy-service agree

@MichalStrehovsky

Copy link
Copy Markdown
Member

This file is a fork of https://github.com/dotnet/runtime/blob/main/src/tools/illink/src/linker/Linker.Dataflow/ArrayValue.cs, could you please sync this change to that one too?

@larkliy larkliy requested a review from sbomer as a code owner March 30, 2026 08:15
@dotnet-policy-service dotnet-policy-service Bot added the linkable-framework Issues associated with delivering a linker friendly framework label Mar 30, 2026
@larkliy

larkliy commented Mar 30, 2026

Copy link
Copy Markdown
Contributor Author

This file is a fork of https://github.com/dotnet/runtime/blob/main/src/tools/illink/src/linker/Linker.Dataflow/ArrayValue.cs, could you please sync this change to that one too?

Done. Synced the changes.

@MichalStrehovsky MichalStrehovsky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MichalStrehovsky

Copy link
Copy Markdown
Member

/ba-g there are timeouts in unrelated CI legs

@MichalStrehovsky MichalStrehovsky merged commit 5685458 into dotnet:main Mar 31, 2026
129 of 136 checks passed
@larkliy larkliy deleted the fix-ilc-tostring branch March 31, 2026 07:34
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-NativeAOT-coreclr community-contribution Indicates that the PR has been added by a community member linkable-framework Issues associated with delivering a linker friendly framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants