[cDAC] Implement GetTieredVersions for cDAC#126164
Merged
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag |
Contributor
There was a problem hiding this comment.
Pull request overview
Implements ISOSDacInterface5.GetTieredVersions in the cDAC by exposing optimization-tier data through contracts/metadata and using it to classify native code versions (R2R vs tiered compilation tiers vs minopts/optimized fallbacks).
Changes:
- Add optimization tier plumbing to contracts/data models (
NativeCodeVersionNode,MethodDescCodeData) and exposeEEConfig+ debugger control globals needed for tier classification. - Implement
SOSDacImpl.GetTieredVersionsusing the new contract APIs and map contract tiers to the legacyDacpTieredVersionData.OptimizationTiervalues. - Add unit tests for
ICodeVersions.GetOptimizationTier(explicit/synthetic handles + missing-field fallback).
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/native/managed/cdac/tests/MockDescriptors/MockDescriptors.CodeVersions.cs | Extend mock NativeCodeVersionNode layout to optionally include OptimizationTier. |
| src/native/managed/cdac/tests/CodeVersionsTests.cs | Add parameterized tests for ICodeVersions.GetOptimizationTier behaviors. |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.cs | Implement ISOSDacInterface5.GetTieredVersions using cDAC contracts and tier mapping logic. |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ISOSDacInterface.cs | Introduce DacpTieredVersionData struct and update GetTieredVersions signature to use it. |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Data/NativeCodeVersionNode.cs | Add optional OptimizationTier field reading from the target. |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Data/MethodDescCodeData.cs | Add optional OptimizationTier field reading from the target. |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Data/EEConfig.cs | New data model for reading EEConfig tiering/debug/minopts settings from the target. |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeTypeSystem_1.cs | Add tier-related RTS APIs: per-method tier, initial tier, eligibility, and JIT-opt-disabled detection. |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/Loader_1.cs | Add IsReadyToRun and GetDebuggerInfoBits, plus module flag plumbing for profiler opt-disable. |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/CodeVersions_1.cs | Add ICodeVersions.GetOptimizationTier implementation (explicit + synthetic). |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Constants.cs | Expose new globals: CORDebuggerControlFlags and EEConfig. |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/DataType.cs | Add DataType.EEConfig. |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs | Add tiering/JIT-opt-disabled APIs and DebuggerControlFlag enum. |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/ILoader.cs | Add R2R + debugger-info APIs and new module flags/DebuggerAssemblyControlFlags. |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/ICodeVersions.cs | Add GetOptimizationTier API and NativeCodeVersionOptimizationTier enum. |
| src/coreclr/vm/eeconfig.h | Export EEConfig fields via cdac_data<EEConfig> for contract reading. |
| src/coreclr/vm/datadescriptor/datadescriptor.inc | Add CDAC descriptors for EEConfig and new globals/fields (OptimizationTier, EEConfig, CORDebuggerControlFlags). |
| src/coreclr/vm/codeversion.h | Export NativeCodeVersionNode::m_optTier offset via cdac_data. |
rcj1
reviewed
Mar 26, 2026
rcj1
reviewed
Mar 26, 2026
rcj1
reviewed
Mar 26, 2026
rcj1
reviewed
Mar 26, 2026
rcj1
reviewed
Mar 26, 2026
rcj1
reviewed
Mar 26, 2026
Contributor
|
Please update the docs for the contracts you updated |
rcj1
reviewed
Mar 27, 2026
Member
|
#119879 has earlier abandoned version of this change. It has discussion about needing to refactor the runtime implementation before it gets exposed via cDAC. Are we no longer planning to do that? |
Contributor
jkotas
reviewed
Mar 27, 2026
noahfalk
reviewed
Mar 27, 2026
jkotas
reviewed
Mar 28, 2026
This was referenced Mar 28, 2026
max-charlamb
approved these changes
Apr 2, 2026
max-charlamb
left a comment
Member
There was a problem hiding this comment.
looks good modulo style nits
Co-authored-by: Max Charlamb <44248479+max-charlamb@users.noreply.github.com>
This was referenced Apr 3, 2026
radekdoulik
pushed a commit
to radekdoulik/runtime
that referenced
this pull request
Apr 9, 2026
## Summary Implement `ISOSDacInterface5.GetTieredVersions` for the cDAC. Each native code version is classified into the correct optimization tier by checking R2R image bounds and tiered-compilation eligibility. Non-tiered methods and methods without generated code report Unknown instead of mirroring runtime policy calculations, keeping the contract surface minimal. The native DAC in request.cpp is updated to match. ## Changes **Native (C++):** Expose `OptimizationTier` on `NativeCodeVersionNode` and `MethodDescCodeData`. Simplify native DAC GetTieredVersions to report Unknown for non-tiered methods. **Contracts & abstractions:** - `ICodeVersions` — `GetOptimizationTier`, `OptimizationTier` enum - `IRuntimeTypeSystem` — `GetMethodDescOptimizationTier`, `IsEligibleForTieredCompilation` - `ILoader` — `IsReadyToRun` **Legacy layer:** Full `SOSDacImpl.GetTieredVersions` implementation with newly added `DacpTieredVersionData` struct and `#if DEBUG` validation against the legacy impl. **Data:** `OptimizationTier` field in `MethodDescCodeData` and `NativeCodeVersionNode`. ## Test Results Parameterized tests covering explicit handles (all tier values), synthetic handles (RTS delegation + unknown-when-no-code-data), R2R detection, buffer truncation, invalid inputs, and non-tiered methods reporting Unknown. --------- Co-authored-by: Max Charlamb <44248479+max-charlamb@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement
ISOSDacInterface5.GetTieredVersionsfor the cDAC. Each native code version is classified into the correct optimization tier by checking R2R image bounds and tiered-compilation eligibility.Non-tiered methods and methods without generated code report Unknown instead of mirroring runtime policy calculations, keeping the contract surface minimal. The native DAC in request.cpp is updated to match.
Changes
Native (C++): Expose
OptimizationTieronNativeCodeVersionNodeandMethodDescCodeData. Simplifynative DAC GetTieredVersions to report Unknown for non-tiered methods.
Contracts & abstractions:
ICodeVersions—GetOptimizationTier,OptimizationTierenumIRuntimeTypeSystem—GetMethodDescOptimizationTier,IsEligibleForTieredCompilationILoader—IsReadyToRunLegacy layer: Full
SOSDacImpl.GetTieredVersionsimplementation with newly addedDacpTieredVersionDatastruct and#if DEBUGvalidation against the legacy impl.Data:
OptimizationTierfield inMethodDescCodeDataandNativeCodeVersionNode.Test Results
Parameterized tests covering explicit handles (all tier values), synthetic handles (RTS delegation + unknown-when-no-code-data), R2R detection, buffer truncation, invalid inputs, and non-tiered methods reporting Unknown.