Rewrite BigInteger internals to use native-width (nuint) limbs#125799

Merged

stephentoub merged 31 commits into

dotnet:mainfrom

stephentoub:biginteger-nuint-rewrite

Mar 27, 2026

Commits on Mar 27, 2026

Convert Number.BigInteger.cs from uint limbs to nuint limbs

stephentoub
and
Copilot
committed
Convert BigInteger internal representation from uint to nuint limbs

stephentoub
and
Copilot
committed
Fix SubWithBorrow sign-extension bug on 32-bit and update stale comments

stephentoub
and
Copilot
committed
Use branchless underflow detection in SubtractDivisor

stephentoub
and
Copilot
committed
Fuse two's complement conversion with bitwise AND/OR/XOR

stephentoub
and
Copilot
committed
Cache PowersOf1e9 table for repeated ToString/Parse calls

stephentoub
and
Copilot
committed
Tune Burnikel-Ziegler division threshold for 64-bit limbs

stephentoub
and
Copilot
committed
Add property-based validation tests and fix BitwiseAnd sign bug

stephentoub
and
Copilot
committed
Add edge-case tests for sign combos, SIMD boundaries, and coverage gaps

stephentoub
and
Copilot
committed
Add Montgomery multiplication for ModPow with odd moduli

stephentoub
and
Copilot
committed
Add tests for Barrett+FastReducer with even large moduli

stephentoub
and
Copilot
committed
Add sliding window exponentiation and separate squaring thresholds

stephentoub
and
Copilot
committed
Avoid array copy in GCD when one operand is zero

stephentoub
and
Copilot
committed
Optimize GCD LehmerCore and DivRem to avoid Int128/UInt128 overhead

stephentoub
and
Copilot
committed
Fix ToString Naive loop regression by processing 32-bit halves

stephentoub
and
Copilot
committed
Fix small-operand, GCD LehmerCore, and ToByteArray regressions

stephentoub
and
Copilot
committed
Add unrolled Mul1/MulAdd1/SubMul1 primitives for multiply and division inner loops

stephentoub
and
Copilot
committed
Replace Unsafe.Add with span indexing using bounds hints for JIT elision

stephentoub
and
Copilot
committed
Use hardware intrinsics for BigMul, DivRem, and AddWithCarry primitives

stephentoub
and
Copilot
committed
Revert _sign from nint to int to eliminate small-value regressions

stephentoub
and
Copilot
committed
Use ulong arithmetic in PowCore when modulus fits in uint

stephentoub
and
Copilot
committed
Clean up formatting / style
stephentoub
committed
Fix SubtractSelf callers to restore borrow==0 postcondition

stephentoub
and
Copilot
committed
Address PR feedback
stephentoub
committed
Address feedback
stephentoub
committed
Fix GetSignBitsIfValid XML doc to clarify 'valid hex digit and considered positive'

stephentoub
and
Copilot
committed
Add comment explaining nuint[] for base-1e9 intermediate representation

stephentoub
and
Copilot
committed
Address review feedback

stephentoub
and
Copilot
committed
Use int loop index in right-shift test to avoid unnecessary nuint casts

stephentoub
and
Copilot
committed
Implement ISerializable on BigInteger for backward-compatible serialization

stephentoub
and
Copilot
committed
Use Buffer.BlockCopy instead of Array.Copy for nuint[]/uint[] conversion

stephentoub
and
Copilot
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rewrite BigInteger internals to use native-width (nuint) limbs#125799

Rewrite BigInteger internals to use native-width (nuint) limbs#125799
stephentoub merged 31 commits into
dotnet:mainfrom
stephentoub:biginteger-nuint-rewrite

Commits on Mar 27, 2026

Convert Number.BigInteger.cs from uint limbs to nuint limbs

Convert BigInteger internal representation from uint to nuint limbs

Fix SubWithBorrow sign-extension bug on 32-bit and update stale comments

Use branchless underflow detection in SubtractDivisor

Fuse two's complement conversion with bitwise AND/OR/XOR

Cache PowersOf1e9 table for repeated ToString/Parse calls

Tune Burnikel-Ziegler division threshold for 64-bit limbs

Add property-based validation tests and fix BitwiseAnd sign bug

Add edge-case tests for sign combos, SIMD boundaries, and coverage gaps

Add Montgomery multiplication for ModPow with odd moduli

Add tests for Barrett+FastReducer with even large moduli

Add sliding window exponentiation and separate squaring thresholds

Avoid array copy in GCD when one operand is zero

Optimize GCD LehmerCore and DivRem to avoid Int128/UInt128 overhead

Fix ToString Naive loop regression by processing 32-bit halves

Fix small-operand, GCD LehmerCore, and ToByteArray regressions

Add unrolled Mul1/MulAdd1/SubMul1 primitives for multiply and division inner loops

Replace Unsafe.Add with span indexing using bounds hints for JIT elision

Use hardware intrinsics for BigMul, DivRem, and AddWithCarry primitives

Revert _sign from nint to int to eliminate small-value regressions

Use ulong arithmetic in PowCore when modulus fits in uint

Clean up formatting / style

Fix SubtractSelf callers to restore borrow==0 postcondition

Address PR feedback

Address feedback

Fix GetSignBitsIfValid XML doc to clarify 'valid hex digit and considered positive'

Add comment explaining nuint[] for base-1e9 intermediate representation

Address review feedback

Use int loop index in right-shift test to avoid unnecessary nuint casts

Implement ISerializable on BigInteger for backward-compatible serialization

Use Buffer.BlockCopy instead of Array.Copy for nuint[]/uint[] conversion