Add openbsd non-portable probing#125557
Merged
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @agocke, @jeffschwMSFT, @elinor-fung |
This was referenced Mar 14, 2026
This was referenced Mar 17, 2026
elinor-fung
approved these changes
Mar 20, 2026
elinor-fung
left a comment
Member
There was a problem hiding this comment.
This looks good to me from the parity perspective.
What part of the build was failing? I'm missing why this fallback path would affect just building host.native.
This was referenced Mar 20, 2026
Member
Author
Sorry I misspoke. It wasn't a failure on main, the failure showed up while I was working on non-portable RID bits. OpenBSD has similarities with FreeBSD and SunOS. Here I had to align with sun-like headers to fix the failure. |
Member
Author
|
CI failures are unrelated (timeouts and QUIC test failure). |
Member
|
/ba-g #125806 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fallback code (
get_current_os_rid_platform) will probably go away in the future once #125076 has landed, but as it stands, we need this for parity. C++ libraries version-less symlinks are needed for cmake/clang to avoid falling back to non-fPIC libc++.a (because libc++.so.x.y is versioned).With this patch,
./build.sh host.native --cross --os openbsd --arch x64succeeds.Upstream PR for eng/common change: dotnet/arcade#16564