[release/10.0] Fix TOCTOU race in AppDomain::LoadAssembly fast-path#125424
Open
github-actions[bot] wants to merge 1 commit intorelease/10.0from
Open
[release/10.0] Fix TOCTOU race in AppDomain::LoadAssembly fast-path#125424github-actions[bot] wants to merge 1 commit intorelease/10.0from
github-actions[bot] wants to merge 1 commit intorelease/10.0from
Conversation
PR #120515 deferred Assembly creation (lazy init), making FileLoadLock::m_pAssembly mutable. The fast-path in LoadAssembly cached pAssembly before checking GetLoadLevel(), so a thread could read nullptr, get preempted while another thread completed the load, then pass the level check and dereference the stale nullptr. Re-read pAssembly from the FileLoadLock inside the fast-path block after the level check passes, ensuring we use the pointer that corresponds to the observed load level. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Tagging subscribers to this area: @agocke |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #125408 to release/10.0
/cc @AaronRobinsonMSFT
Customer Impact
[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.]
Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
[How was the fix verified? How was the issue missed previously? What tests were added?]
Risk
[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging, notrelease/X.0.release/X.0(no-stagingsuffix).Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.