Skip to content

Remove ActiveIssue skips for fixed issue #122547 in async reflection tests#125423

Closed
Copilot wants to merge 2 commits intomainfrom
copilot/remove-active-issue-attributes
Closed

Remove ActiveIssue skips for fixed issue #122547 in async reflection tests#125423
Copilot wants to merge 2 commits intomainfrom
copilot/remove-active-issue-attributes

Conversation

Copy link
Contributor

Copilot AI commented Mar 11, 2026

Issue #122547 ("Stack traces with async variants") is fixed and closed, but FromStack and FromStackDMI in src/tests/async/reflection/reflection.cs were still skipped via [ActiveIssue] attributes referencing it.

Description

Removes three [ActiveIssue("https://github.com/dotnet/runtime/issues/122547", ...)] attributes:

  • FromStack — was skipped on IsCoreClrInterpreter
  • FromStackDMI — was skipped on both IsNativeAot and IsCoreClrInterpreter

FromStack retains its existing runtime if (IsNativeAot) return; guard (unrelated to #122547StackFrame.GetMethod() is unsupported on NativeAOT). FromStackDMI uses DiagnosticMethodInfo.Create which has no such limitation.

Original prompt

Background

Issue #122547 ("Stack traces with async variants") has been fixed and closed. However, there are tests in src/tests/async/reflection/reflection.cs that are still skipped via [ActiveIssue] attributes referencing that issue.

What to change

In src/tests/async/reflection/reflection.cs, remove all three [ActiveIssue] attributes that reference issue #122547:

  1. Line 290 — on the FromStack test method:

    [ActiveIssue("https://github.com/dotnet/runtime/issues/122547", typeof(TestLibrary.Utilities), nameof(TestLibrary.Utilities.IsCoreClrInterpreter))]
  2. Lines 352–353 — on the FromStackDMI test method:

    [ActiveIssue("https://github.com/dotnet/runtime/issues/122547", typeof(TestLibrary.Utilities), nameof(TestLibrary.Utilities.IsNativeAot))]
    [ActiveIssue("https://github.com/dotnet/runtime/issues/122547", typeof(TestLibrary.Utilities), nameof(TestLibrary.Utilities.IsCoreClrInterpreter))]

After removing these three attributes, the FromStack test will run on the CoreCLR interpreter, and FromStackDMI will run on both NativeAOT and the CoreCLR interpreter.

No other changes are needed.

The following is the prior conversation context from the user's chat exploration (may be truncated):

User: @dotnet/runtime/issues/122547 was fixed but we still have tests blocked on this issue. make a PR that starts running the tests.

Assistant: Now I have a clear picture of all the [ActiveIssue] annotations blocking tests on issue #122547. There are two tests with these attributes:

  1. FromStack (line 290) — blocked for IsCoreClrInterpreter
  2. FromStackDMI (lines 352–353) — blocked for both IsNativeAot AND IsCoreClrInterpreter

The fix is to remove all three [ActiveIssue("https://github.com/dotnet/runtime/issues/122547", ...)] attributes since the issue is now closed/fixed.

Assistant: We're waiting for your response to the tool call dialog to continue creating the pull request.

This pull request was created from Copilot chat.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib
See info in area-owners.md if you want to be subscribed.

…ests

Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove ActiveIssue attributes referencing issue #122547 Remove ActiveIssue skips for fixed issue #122547 in async reflection tests Mar 11, 2026
@MichalStrehovsky MichalStrehovsky deleted the copilot/remove-active-issue-attributes branch March 11, 2026 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants