Remove ActiveIssue skips for fixed issue #122547 in async reflection tests#125423
Closed
Remove ActiveIssue skips for fixed issue #122547 in async reflection tests#125423
Conversation
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib |
…ests Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove ActiveIssue attributes referencing issue #122547
Remove ActiveIssue skips for fixed issue #122547 in async reflection tests
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #122547 ("Stack traces with async variants") is fixed and closed, but
FromStackandFromStackDMIinsrc/tests/async/reflection/reflection.cswere still skipped via[ActiveIssue]attributes referencing it.Description
Removes three
[ActiveIssue("https://github.com/dotnet/runtime/issues/122547", ...)]attributes:FromStack— was skipped onIsCoreClrInterpreterFromStackDMI— was skipped on bothIsNativeAotandIsCoreClrInterpreterFromStackretains its existing runtimeif (IsNativeAot) return;guard (unrelated to #122547 —StackFrame.GetMethod()is unsupported on NativeAOT).FromStackDMIusesDiagnosticMethodInfo.Createwhich has no such limitation.Original prompt
This pull request was created from Copilot chat.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.