JIT: Share suspension epilogs in async transformation#125174
Draft
jakobbotsch wants to merge 4 commits intodotnet:mainfrom
Draft
JIT: Share suspension epilogs in async transformation#125174jakobbotsch wants to merge 4 commits intodotnet:mainfrom
jakobbotsch wants to merge 4 commits intodotnet:mainfrom
Conversation
If we have more than one await, then create a shared `GT_RETURN_SUSPEND` block and use that for suspension always.
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes the CoreCLR JIT async transformation to share a single GT_RETURN_SUSPEND “shared return” block when there are multiple awaits, so multiple suspension points can branch to one epilog.
Changes:
- Refactors await discovery into
FindAwaits(...), tracking normal vs tail-awaits and total await counts. - Transforms tail awaits in a first pass (
TransformTailAwaits(...)) and re-scans when needed. - Introduces
CreateSharedReturnBB()to create a sharedGT_RETURN_SUSPENDblock when#awaits > 1.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/coreclr/jit/async.h | Adds declarations for await discovery, tail-await batch transform, and shared return block creation. |
| src/coreclr/jit/async.cpp | Implements the refactor and shared return block creation, and updates tail-await suspension to use m_sharedReturnBB. |
This was referenced Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we have more than one await, then create a shared
GT_RETURN_SUSPENDblock and use that for suspension always.