Skip to content

Add CodeQL query exclusions for dangerous deserialization rules#125016

Merged
GrabYourPitchforks merged 5 commits intomainfrom
levib/codeql-deserialization-exclusions
Mar 5, 2026
Merged

Add CodeQL query exclusions for dangerous deserialization rules#125016
GrabYourPitchforks merged 5 commits intomainfrom
levib/codeql-deserialization-exclusions

Conversation

@GrabYourPitchforks
Copy link
Member

See dotnet/winforms#14240 for context.

For the dotnet/runtime repo, this should silence around 470 alerts from our internal work item database once it's fully ingested by TSA.

Copilot AI review requested due to automatic review settings February 28, 2026 21:01
@github-actions github-actions bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 28, 2026
@GrabYourPitchforks GrabYourPitchforks added area-Meta and removed area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Feb 28, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds CodeQL query exclusions to the .CodeQL.yml configuration file for the dotnet/runtime repository, mirroring a similar change made in dotnet/winforms#14240. The goal is to suppress approximately 470 false-positive alerts from three dangerous-deserialization CodeQL rules that do not accurately reflect the security posture of this codebase (where [Serializable] expresses capability, not a safety guarantee, and call sites are already reviewed by other tooling).

Changes:

  • Updated an internal documentation URL in the header comment to reflect a path restructure (cloud-ai-platformcoreai).
  • Added a queries section with repo-wide exclusions for three CodeQL C# deserialization alert rules.

Copilot AI review requested due to automatic review settings March 1, 2026 00:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@GrabYourPitchforks GrabYourPitchforks enabled auto-merge (squash) March 2, 2026 19:08
@GrabYourPitchforks GrabYourPitchforks merged commit fc40302 into main Mar 5, 2026
156 checks passed
@GrabYourPitchforks GrabYourPitchforks deleted the levib/codeql-deserialization-exclusions branch March 5, 2026 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants