Implement ISOSDacInterface::GetThreadAllocData in cDAC SOSDacImpl by Copilot · Pull Request #124817 · dotnet/runtime

Copilot · 2026-02-24T20:23:27Z

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

dotnet-policy-service · 2026-02-24T20:40:47Z

Tagging subscribers to this area: @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

- Add AllocBytes and AllocBytesLoh fields to GCAllocContext data descriptor - Add ThreadAllocData record struct and GetThreadAllocData to IThread contract - Implement GetThreadAllocData in Thread_1.cs contract - Define DacpAllocData managed struct in ISOSDacInterface.cs - Implement GetThreadAllocData in SOSDacImpl.cs with DEBUG comparison - Add unit tests for GetThreadAllocData with non-zero and zero values - Add dump test for GetThreadAllocData - Update Thread.md and GC.md documentation Co-authored-by: max-charlamb <44248479+max-charlamb@users.noreply.github.com>

Co-authored-by: max-charlamb <44248479+max-charlamb@users.noreply.github.com>

max-charlamb

@copilot , address feedback

src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.cs

...tive/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IThread.cs

…eption for E_POINTER, rename to GetThreadAllocContext Co-authored-by: max-charlamb <44248479+max-charlamb@users.noreply.github.com>

Copilot · 2026-02-24T21:45:34Z

@copilot , address feedback

All three review comments addressed in 9fbc6c9. All 840 tests pass.

max-charlamb

@copilot , address feedback

...native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/Thread_1.cs

Co-authored-by: max-charlamb <44248479+max-charlamb@users.noreply.github.com>

Copilot

Pull request overview

Implements ISOSDacInterface::GetThreadAllocData in the cDAC-based SOSDacImpl by exposing per-thread GC allocation byte counters from gc_alloc_context through the managed contracts and data descriptors.

Changes:

Added AllocBytes / AllocBytesLoh fields to the GCAllocContext data descriptor and managed data model.
Extended the IThread contract with GetThreadAllocContext returning a new ThreadAllocData record, and wired it into SOSDacImpl.GetThreadAllocData.
Added unit + dump tests and updated mock descriptors and design docs to cover/describe the new fields.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/native/managed/cdac/tests/ThreadTests.cs	Adds unit tests for `GetThreadAllocContext`.
src/native/managed/cdac/tests/MockDescriptors/MockDescriptors.Thread.cs	Extends mock type layouts and thread creation to include alloc-context hierarchy and alloc byte values.
src/native/managed/cdac/tests/DumpTests/ThreadDumpTests.cs	Adds dump test to validate alloc context can be read across all threads.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/SOSDacImpl.cs	Implements `GetThreadAllocData` using the `IThread` contract and follows existing try/catch + DEBUG-compare patterns.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ISOSDacInterface.cs	Introduces `DacpAllocData` and updates the interface signature to use it.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Data/GCAllocContext.cs	Reads new alloc-byte fields from the target in managed data representation.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/Thread_1.cs	Implements `IThread.GetThreadAllocContext`.
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IThread.cs	Adds `ThreadAllocData` record and the new contract method.
src/coreclr/vm/datadescriptor/datadescriptor.inc	Adds `GCAllocContext` field descriptors for alloc byte counts.
docs/design/datacontracts/Thread.md	Documents new `GCAllocContext` field dependencies for the Thread contract.
docs/design/datacontracts/GC.md	Documents new `GCAllocContext` field descriptors used by GC-related contracts.

src/native/managed/cdac/tests/ThreadTests.cs

...ative/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Data/GCAllocContext.cs

max-charlamb · 2026-02-24T22:36:48Z

@copilot, please fix build break

…dAllocContext test and fix trailing whitespace Co-authored-by: max-charlamb <44248479+max-charlamb@users.noreply.github.com>

Copilot · 2026-02-24T22:41:38Z

@copilot, please fix build break

Fixed in 0e5922e — the GetThreadAllocContext test was missing TargetTestHelpers/MockMemorySpace.Builder/MockDescriptors.Thread setup. Also cleaned up remaining trailing whitespace in Thread_1.cs. All 24 thread tests pass.

...tive/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IThread.cs

…ontext Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

max-charlamb

@copilot , address feedback

docs/design/datacontracts/GC.md

Co-authored-by: max-charlamb <44248479+max-charlamb@users.noreply.github.com>

Copilot · 2026-02-25T16:35:28Z

@copilot , address feedback

Merge conflict artifacts in GC.md fixed in 70d85a9. All 24 thread tests pass.

@copilot, please fix build break

Build is clean — all 876 cDAC tests pass. The merge conflict artifacts in GC.md have been fixed in 70d85a9.

max-charlamb

changes lgtm

Initial plan

31fae06

Copilot AI assigned Copilot and max-charlamb Feb 24, 2026

Copilot started work on behalf of max-charlamb February 24, 2026 20:23 View session

github-actions bot added the area-System.Threading label Feb 24, 2026

Copilot AI and others added 2 commits February 24, 2026 21:02

Fix documentation: align field descriptions with native comments

764358c

Co-authored-by: max-charlamb <44248479+max-charlamb@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Implement GetThreadAllocData in SOSDacImpl~~ Implement ISOSDacInterface::GetThreadAllocData in cDAC SOSDacImpl Feb 24, 2026

Copilot finished work on behalf of max-charlamb February 24, 2026 21:09

max-charlamb reviewed Feb 24, 2026

View reviewed changes

Copilot started work on behalf of max-charlamb February 24, 2026 21:38 View session

Address review feedback: move checks inside try, use NullReferenceExc…

9fbc6c9

…eption for E_POINTER, rename to GetThreadAllocContext Co-authored-by: max-charlamb <44248479+max-charlamb@users.noreply.github.com>

Copilot finished work on behalf of max-charlamb February 24, 2026 21:46

Merge branch 'main' into copilot/implement-get-thread-alloc-data

a4ca9e9

max-charlamb reviewed Feb 24, 2026

View reviewed changes

...native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/Thread_1.cs Outdated Show resolved Hide resolved

max-charlamb marked this pull request as ready for review February 24, 2026 21:52

Copilot AI review requested due to automatic review settings February 24, 2026 21:52

Copilot started work on behalf of max-charlamb February 24, 2026 21:52 View session

Copilot started reviewing on behalf of max-charlamb February 24, 2026 21:53 View session

Remove extra trailing whitespace in Thread_1.cs

0abc066

Co-authored-by: max-charlamb <44248479+max-charlamb@users.noreply.github.com>

Copilot finished work on behalf of max-charlamb February 24, 2026 21:56

Copilot AI reviewed Feb 24, 2026

View reviewed changes

src/native/managed/cdac/tests/ThreadTests.cs Show resolved Hide resolved

...ative/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Data/GCAllocContext.cs Show resolved Hide resolved

max-charlamb requested a review from rcj1 February 24, 2026 22:36

Copilot started work on behalf of max-charlamb February 24, 2026 22:36 View session

Fix build break: add missing MockDescriptors.Thread setup in GetThrea…

0e5922e

…dAllocContext test and fix trailing whitespace Co-authored-by: max-charlamb <44248479+max-charlamb@users.noreply.github.com>

Copilot finished work on behalf of max-charlamb February 24, 2026 22:42

rcj1 reviewed Feb 24, 2026

View reviewed changes

...tive/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IThread.cs Outdated Show resolved Hide resolved

Copilot started work on behalf of rcj1 February 24, 2026 22:45 View session

Replace ThreadAllocData struct with out parameters on GetThreadAllocC…

fa4b867

…ontext Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Copilot finished work on behalf of rcj1 February 24, 2026 22:54

Merge branch 'main' into copilot/implement-get-thread-alloc-data

1cffacf

max-charlamb reviewed Feb 25, 2026

View reviewed changes

docs/design/datacontracts/GC.md Outdated Show resolved Hide resolved

Copilot started work on behalf of max-charlamb February 25, 2026 16:13 View session

Fix merge conflict artifacts in GC.md

70d85a9

Co-authored-by: max-charlamb <44248479+max-charlamb@users.noreply.github.com>

Copilot finished work on behalf of max-charlamb February 25, 2026 16:36

max-charlamb approved these changes Feb 25, 2026

View reviewed changes

max-charlamb requested a review from rcj1 February 25, 2026 18:44

build-analysis bot mentioned this pull request Feb 25, 2026

slow macOS - "##[error]The job running on agent Azure Pipelines 9 ran longer than the maximum time of 60 minutes." dotnet/dnceng#1883

Open

3 tasks

max-charlamb requested review from barosiak and noahfalk February 25, 2026 21:44

rcj1 approved these changes Feb 26, 2026

View reviewed changes

noahfalk approved these changes Feb 26, 2026

View reviewed changes

max-charlamb merged commit c746487 into main Feb 26, 2026
109 of 114 checks passed

max-charlamb deleted the copilot/implement-get-thread-alloc-data branch February 26, 2026 16:53

dotnet-maestro bot mentioned this pull request Feb 27, 2026

[main] Source code updates from dotnet/runtime dotnet/dotnet#5129

Merged

Conversation

Copilot AI commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dotnet-policy-service bot commented Feb 24, 2026

Uh oh!

max-charlamb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Feb 24, 2026

Uh oh!

max-charlamb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

max-charlamb commented Feb 24, 2026

Uh oh!

Copilot AI commented Feb 24, 2026

Uh oh!

Uh oh!

max-charlamb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

max-charlamb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Copilot AI commented Feb 24, 2026 •

edited

Loading

Copilot AI commented Feb 25, 2026 •

edited

Loading