Remove calls to ToArray because string.Join already has overload for ROS<string>.#124792
Merged
cincuranet merged 1 commit intodotnet:mainfrom Feb 25, 2026
Merged
Remove calls to ToArray because string.Join already has overload for ROS<string>.#124792cincuranet merged 1 commit intodotnet:mainfrom
cincuranet merged 1 commit intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/ncl |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes string concatenation in logging code by removing unnecessary .ToArray() calls when using string.Join() with ReadOnlySpan<string> parameters. The string.Join method has overloads that accept ReadOnlySpan<string?> directly, making the array allocation unnecessary and improving performance.
Changes:
- Removed
.ToArray()calls in two logging statements withinHttp2Connection.cs - Reduced allocations in diagnostic/tracing code paths that are conditionally enabled
stephentoub
approved these changes
Feb 24, 2026
MihaZupan
approved these changes
Feb 24, 2026
This was referenced Feb 24, 2026
Contributor
Author
|
/ba-g Failures are unrelated. |
iremyux
pushed a commit
to iremyux/dotnet-runtime
that referenced
this pull request
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.