Merged
Conversation
This got broken in #111514. Technically this means the change should be labeled as a breaking change, but I'm not sure if these are really user scenarios.
Member
Author
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib |
Member
Author
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the System.Diagnostics.Process test project’s handling of the LongPath helper assembly to restore NativeAOT outerloop behavior that regressed after #111514, by ensuring the helper DLL is copied as content rather than treated as a referenced assembly.
Changes:
- Marks the
LongPathproject reference as non-referenced (ReferenceOutputAssembly=false) while still copying its output to the test output directory. - Keeps
LongPath.dllexcluded from ReadyToRun publish processing.
Comments suppressed due to low confidence (1)
src/libraries/System.Diagnostics.Process/tests/System.Diagnostics.Process.Tests.csproj:90
- With this ProjectReference now marked as content-only (
ReferenceOutputAssembly=false+OutputItemType=Content), the nearby comment about the combination of a regular project reference and a content reference no longer seems to describe the situation in this file. Consider updating that comment (and double-checking whetherPublishReadyToRunExcludeis still required) so future maintainers understand the real reason for the exclusion.
<ReferenceOutputAssembly>false</ReferenceOutputAssembly>
<OutputItemType>Content</OutputItemType>
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</ProjectReference>
<!-- R2R testing does not tolerate the combination of a regular project reference and a content reference. -->
<!-- This is a bug in the SDK tracked here: https://github.com/dotnet/sdk/issues/30718 -->
<PublishReadyToRunExclude Include="LongPath.dll" />
3 tasks
Member
|
Fixes #124723 ? |
iremyux
pushed a commit
to iremyux/dotnet-runtime
that referenced
this pull request
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This got broken in #111514.
Technically this means the change should be labeled as a breaking change, but I'm not sure if these are really user scenarios.