[wasm][coreclr] Use 4GB limit for corerun#124633
Merged
radekdoulik merged 1 commit intodotnet:mainfrom Feb 22, 2026
Merged
Conversation
And enable disabled test
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/runtime-infrastructure |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the WASM/CoreCLR corerun host to allow growth up to a 4GB WebAssembly linear memory limit, and re-enables a previously skipped JIT regression test that exercises very large array allocations.
Changes:
- Increase
corerun’s Emscripten-sMAXIMUM_MEMORYfrom 2GB to 4GB for browser/wasm builds. - Remove the WASM-targeted
ActiveIssueAttributeskip fromjit64/regress/vsw/373472to re-enable the test on WASM.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/tests/JIT/jit64/regress/vsw/373472/test.il |
Removes the WASM ActiveIssueAttribute so the large-array regression runs on WASM again. |
src/coreclr/hosts/corerun/CMakeLists.txt |
Raises Emscripten maximum memory setting to 4GB so large allocations required by runtime tests can succeed. |
Member
Author
|
/ba-g the failures are unrelated |
AaronRobinsonMSFT
approved these changes
Feb 20, 2026
This was referenced Feb 23, 2026
iremyux
pushed a commit
to iremyux/dotnet-runtime
that referenced
this pull request
Mar 2, 2026
And enable disabled test. This is follow up to dotnet#123377 where this change was disabled as potential problem when looking for regression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And enable disabled test.
This is follow up to #123377 where this change was disabled as potential problem when looking for regression.