Skip to content

[X86][APX] Update the CPUID check logics for APX. #124624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ruihan-Yin wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[X86][APX] Update the CPUID check logics for APX. #124624

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
eae05a8
update the CPUID check logics for APX.
Ruihan-Yin Feb 18, 2026
f6c6e30
add maxCpuId check when checking cpuid(0x29, 0)
Ruihan-Yin Feb 20, 2026
3d157c9
resolve comments
Ruihan-Yin Feb 27, 2026
6d42295
Update src/native/minipal/cpufeatures.c
Ruihan-Yin Feb 27, 2026
993a8d4
Update comments
Ruihan-Yin Mar 2, 2026
f046b4e
Update src/native/minipal/cpufeatures.c
Ruihan-Yin Mar 5, 2026
e0dba1c
Update src/native/minipal/cpufeatures.c
Ruihan-Yin Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions src/native/minipal/cpufeatures.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,7 @@ int minipal_getcpufeatures(void)

bool hasAvx2Dependencies = false;
bool hasAvx10v1Dependencies = false;
bool hasApxDependencies = false;

if (((cpuidInfo[CPUID_EDX] & (1 << 25)) == 0) || // SSE
((cpuidInfo[CPUID_EDX] & (1 << 26)) == 0) || // SSE2
Expand Down Expand Up @@ -406,9 +407,13 @@ int minipal_getcpufeatures(void)

if (IsApxEnabled() && apxStateSupport())
{
if ((cpuidInfo[CPUID_EDX] & (1 << 21)) != 0) // Apx
if ((cpuidInfo[CPUID_EDX] & (1 << 21)) != 0) // Apx_F
{
result |= XArchIntrinsicConstants_Apx;
// APX availability check is split into two parts, Apx_F here
// checks the fundamental support, and APX_NCI_NDD_NF checks
// feature support.
// Full APX requires both parts to be present to be enabled.
hasApxDependencies = true;
}
}
}
Expand Down Expand Up @@ -446,6 +451,15 @@ int minipal_getcpufeatures(void)
}
}
}

if (maxCpuId >= 0x29)
{
__cpuidex(cpuidInfo, 0x00000029, 0x00000000);
if (((cpuidInfo[CPUID_EBX] & (1 << 0)) != 0) && hasApxDependencies) // APX_NCI_NDD_NF
{
result |= XArchIntrinsicConstants_Apx;
}
}
}
#endif // HOST_X86 || HOST_AMD64

Expand Down
Loading