Re-enable SslStreamTlsResumeTests.ClientDisableTlsResume_Succeeds#124463
Merged
Re-enable SslStreamTlsResumeTests.ClientDisableTlsResume_Succeeds#124463
Conversation
Co-authored-by: rzikm <32671551+rzikm@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix SslStreamTlsResumeTests.ClientDisableTlsResume_Succeeds CI failure
Re-enable SslStreamTlsResumeTests.ClientDisableTlsResume_Succeeds
Feb 16, 2026
Member
|
I can't reproduce the issue locally, I will see if it reproduces overnight, otherwise, I think we can merge this |
Contributor
|
Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones |
Contributor
There was a problem hiding this comment.
Pull request overview
Re-enables the SslStreamTlsResumeTests.ClientDisableTlsResume_Succeeds functional test in System.Net.Security by removing the Windows-specific [ActiveIssue] skip, based on indications that the underlying SChannel/session resumption flakiness has been addressed.
Changes:
- Remove the
[ActiveIssue("https://github.com/dotnet/runtime/issues/103449", TestPlatforms.Windows)]attribute fromClientDisableTlsResume_Succeeds.
wfurt
approved these changes
Feb 16, 2026
Member
wfurt
left a comment
There was a problem hiding this comment.
I think we can try it. It may be timing problem and/or it may behave different way on different windows versions.
Member
|
/ba-g test failures are not related |
Member
|
The issue did not reproduce locally when run in a loop overnight (it used to in the past), so we can merge this. |
iremyux
pushed a commit
to iremyux/dotnet-runtime
that referenced
this pull request
Mar 2, 2026
…tnet#124463) ## Description Test `ClientDisableTlsResume_Succeeds` was disabled on Windows due to flaky TLS session resumption behavior. Issue comments indicate the underlying SChannel bug was fixed in PR dotnet#113604, but the test remained disabled. Re-enabling to verify resolution in CI. ## Changes - Remove `[ActiveIssue]` attribute from `ClientDisableTlsResume_Succeeds` test method Test validates that setting `AllowTlsResume = false` properly prevents TLS session resumption. Previously failed intermittently on Windows with sessions resuming when they shouldn't. ## Test Results Both parameterized test cases pass on Linux: - `ClientDisableTlsResume_Succeeds(testClient: True)` - `ClientDisableTlsResume_Succeeds(testClient: False)` CI will validate Windows behavior. <!-- START COPILOT ORIGINAL PROMPT --> <details> <summary>Original prompt</summary> > > ---- > > *This section details on the original issue you should resolve* > > <issue_title>SslStreamTlsResumeTests.ClientDisableTlsResume_Succeeds failed in CI</issue_title> > <issue_description>## Build Information > Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=707064 > Build error leg or test failing: System.Net.Security.Tests.SslStreamTlsResumeTests.ClientDisableTlsResume_Succeeds > Pull request: dotnet#103309 > <!-- Error message template --> > ## Error Message > > Fill the error message using [step by step known issues guidance](https://github.com/dotnet/arcade/blob/main/Documentation/Projects/Build%20Analysis/KnownIssueJsonStepByStep.md). > > <!-- Use ErrorMessage for String.Contains matches. Use ErrorPattern for regex matches (single line/no backtracking). Set BuildRetry to `true` to retry builds with this error. Set ExcludeConsoleLog to `true` to skip helix logs analysis. --> > > ```json > { > "ErrorMessage": "ClientDisableTlsResume_Succeeds", > "ErrorPattern": "", > "BuildRetry": false, > "ExcludeConsoleLog": false > } > ``` > > ``` > ❌ System.Net.Security.Tests.SslStreamTlsResumeTests.ClientDisableTlsResume_Succeeds(testClient: True) > Exception Message > TLS session resumed in round $2 > Stack Trace > at System.Net.Security.Tests.SslStreamTlsResumeTests.ClientDisableTlsResume_Succeeds(Boolean testClient) in /_/src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamAllowTlsResumeTests.cs:line 99 > --- End of stack trace from previous location --- > ``` > <!-- Known issue validation start --> > ### Known issue validation > **Build: 🔎** https://dev.azure.com/dnceng-public/public/_build/results?buildId=707064 > **Error message validated:** `[ClientDisableTlsResume_Succeeds`] > **Result validation:** ✅ Known issue matched with the provided build. > **Validation performed at:** 6/14/2024 11:26:27 PM UTC > <!-- Known issue validation end --> > <!--Known issue error report start --> > > ### Report > #### Summary > |24-Hour Hit Count|7-Day Hit Count|1-Month Count| > |---|---|---| > |0|0|0| > <!--Known issue error report end --></issue_description> > > <agent_instructions>Raise a PR which reenables the test to see if the issue persists</agent_instructions> > > ## Comments on the Issue (you are @copilot in this section) > > <comments> > <comment_new><author>@stephentoub</author><body> > @rzikm, can we disable this test? It's failing a lot.</body></comment_new> > <comment_new><author>@rzikm</author><body> > The behavior seems to be flaky and seems to depend on timing, the bug has been passed to SChannel team for investigation.</body></comment_new> > <comment_new><author>@rzikm</author><body> > Removing from 9.0.0, as this is not critical for 9.0 and the SChannel team is currently busy with higher priority investigations.</body></comment_new> > <comment_new><author>@jeffschwMSFT</author><body> > removing blocking-clean-ci as it has not failed in 30 days > > 24-Hour Hit Count | 7-Day Hit Count | 1-Month Count > -- | -- | -- > 0 | 0 | 0 > </body></comment_new> > <comment_new><author>@jkotas</author><body> > This failed again in dotnet#113416 windows-Debug-x64-coreclr_release-Windows.Amd64.Server2022.Open. > > From https://helixr1107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-113416-merge-2f216bd0c68a49be87/System.Net.Security.Tests/3/console.734dc56a.log?helixlogtype=result: > ``` > System.Net.Security.Tests.SslStreamTlsResumeTests.ClientDisableTlsResume_Succeeds(testClient: True) [FAIL] > TLS session resumed in round $2 > Stack Trace: > /_/src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamAllowTlsResumeTests.cs(99,0): at System.Net.Security.Tests.SslStreamTlsResumeTests.ClientDisableTlsResume_Succeeds(Boolean testClient) > --- End of stack trace from previous location --- > ```</body></comment_new> > <comment_new><author>@ManickaP</author><body> > Fixed by https://github.com/dotnet/runtime/pull/113604</body></comment_new> > <comment_new><author>@liveans</author><body> > > Fixed by [dotnet#113604](dotnet#113604) > > This test is still disabled > https://github.com/dotnet/runtime/blob/3057101c0479ff67b389d5a578b3e25cc8b8512a/src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamAllowTlsResumeTests.cs#L37-L38</body></comment_new> > </comments> > </details> <!-- START COPILOT CODING AGENT SUFFIX --> - Fixes dotnet#103449 <!-- START COPILOT CODING AGENT TIPS --> --- 💬 We'd love your input! Share your thoughts on Copilot coding agent in our [2 minute survey](https://gh.io/copilot-coding-agent-survey). --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: rzikm <32671551+rzikm@users.noreply.github.com>
iremyux
pushed a commit
to iremyux/dotnet-runtime
that referenced
this pull request
Mar 2, 2026
…eeds" (dotnet#124542) Reverts dotnet#124463 The tests are failing on Windows 2022 and Windows Nano
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Test
ClientDisableTlsResume_Succeedswas disabled on Windows due to flaky TLS session resumption behavior. Issue comments indicate the underlying SChannel bug was fixed in PR #113604, but the test remained disabled. Re-enabling to verify resolution in CI.Changes
[ActiveIssue]attribute fromClientDisableTlsResume_Succeedstest methodTest validates that setting
AllowTlsResume = falseproperly prevents TLS session resumption. Previously failed intermittently on Windows with sessions resuming when they shouldn't.Test Results
Both parameterized test cases pass on Linux:
ClientDisableTlsResume_Succeeds(testClient: True)ClientDisableTlsResume_Succeeds(testClient: False)CI will validate Windows behavior.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.