Skip to content

Remove assert from AddNecessaryAsyncReferences #124393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jtschuster merged 8 commits into from
Feb 16, 2026
Merged

Remove assert from AddNecessaryAsyncReferences #124393

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
83fb619
feat(r2r): add ModuleTokenResolver.GetModuleTokenForField
jtschuster Feb 3, 2026
ec1caed
Add references for getAsyncInfo in singlethreaded portion
jtschuster Feb 10, 2026
03d019a
Formatting
jtschuster Feb 10, 2026
45baeae
Remove unused variable
jtschuster Feb 10, 2026
c9b12af
Update src/coreclr/tools/aot/ILCompiler.ReadyToRun/Compiler/ReadyToRu…
jtschuster Feb 10, 2026
745a8a6
Update src/coreclr/tools/aot/ILCompiler.ReadyToRun/Compiler/ReadyToRu…
jtschuster Feb 11, 2026
9d7b933
Merge branch 'main' of https://github.com/dotnet/runtime into getAsyn…
jtschuster Feb 13, 2026
d8e1177
Merge branch 'getAsyncInfoReferences' of https://github.com/jtschuste…
jtschuster Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/coreclr/tools/aot/ILCompiler.ReadyToRun/Compiler/ReadyToRunCodegenCompilation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -982,10 +982,8 @@ private void AddNecessaryAsyncReferences(MethodDesc method)

// Keep in sync with CorInfoImpl.getAsyncInfo()
DefType continuation = TypeSystemContext.ContinuationType;
var asyncHelpers = TypeSystemContext.SystemModule.GetKnownType("System.Runtime.CompilerServices"u8, "AsyncHelpers"u8);
// AsyncHelpers should already be referenced in the module for the call to Await()
Debug.Assert(!_nodeFactory.Resolver.GetModuleTokenForType(asyncHelpers, allowDynamicallyCreatedReference: true, throwIfNotFound: false).IsNull);
TypeDesc[] requiredTypes = [continuation];
TypeDesc asyncHelpers = TypeSystemContext.SystemModule.GetKnownType("System.Runtime.CompilerServices"u8, "AsyncHelpers"u8);
TypeDesc[] requiredTypes = [asyncHelpers, continuation];
FieldDesc[] requiredFields =
[
// For CorInfoImpl.getAsyncInfo
Expand Down
Loading