[tests][exceptions] Abbreviate long native test path#116841
Merged
mdh1418 merged 2 commits intodotnet:mainfrom Jun 20, 2025
Merged
[tests][exceptions] Abbreviate long native test path#116841mdh1418 merged 2 commits intodotnet:mainfrom
mdh1418 merged 2 commits intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR shortens native test paths by renaming CMake projects, native libraries, DllImport references, and corresponding C# classes to more concise names under the UnhandledExceptionHandler tests.
- Rename
foreignunhandled→unhandlednativefor the generic unhandled test - Remove old
PInvokeRevPInvokeUnhandledandForeignThreadRevPInvokeUnhandledtests, replacing them withPInvokeUnhandledandForeignUnhandledvariants - Update CMakeLists,
.csproj, and C# sources to reflect the new native library and class names
Reviewed Changes
Copilot reviewed 10 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/tests/baseservices/exceptions/unhandled/unhandled.cs | DllImport and native library name updated |
| src/tests/baseservices/exceptions/unhandled/CMakeLists.txt | CMake project and target renamed |
| src/tests/baseservices/exceptions/UnhandledExceptionHandler/PInvokeRevPInvokeUnhandled | Removed obsolete CMakeLists |
| src/tests/baseservices/exceptions/UnhandledExceptionHandler/PInvoke/PInvokeUnhandled.csproj | Update source file reference in project |
| src/tests/baseservices/exceptions/UnhandledExceptionHandler/PInvoke/PInvokeUnhandled.cs | Rename class, DllImport, and static constructor |
| src/tests/baseservices/exceptions/UnhandledExceptionHandler/PInvoke/CMakeLists.txt | New CMakeLists for PInvokeUnhandledNative |
| src/tests/baseservices/exceptions/UnhandledExceptionHandler/ForeignThreadRevPInvokeUnhandled | Removed obsolete CMakeLists |
| src/tests/baseservices/exceptions/UnhandledExceptionHandler/Foreign/ForeignUnhandled.csproj | Update source file reference in project |
| src/tests/baseservices/exceptions/UnhandledExceptionHandler/Foreign/ForeignUnhandled.cs | Rename class, DllImport, and static constructor |
| src/tests/baseservices/exceptions/UnhandledExceptionHandler/Foreign/CMakeLists.txt | New CMakeLists for ForeignUnhandledNative |
mdh1418
commented
Jun 19, 2025
| { | ||
| [DllImport("ForeignThreadRevPInvokeUnhandled")] |
Member
Author
There was a problem hiding this comment.
Not sure how this dllimport resolved before when the file and cmake used ForeignThreadRevPInvokeUnhandledNative
Member
Author
|
I've also explored putting the two projects directly under UnhandledExceptionHandler, but I'm not familiar enough with the build/CMake to avoid having each other's native files in the test artifacts directories. |
jkoritzinsky
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should partially mitigate #110407
UnhandledExceptionHandler/ForeignThreadRevPInvokeUnhandled/ForeignThreadRevPInvokeUnhandled.*to
UnhandledExceptionHandler/Foreign/ForeignUnhandled.*UnhandledExceptionHandler/PInvokeRevPInvokeUnhandled/PInvokeRevPInvokeUnhandled.*to
UnhandledExceptionHandler/PInvoke/PInvokeUnhandled.*Testing