arm64: Rename CreateBreak/CreateMask args#116255
Merged
kunalspathak merged 2 commits intodotnet:mainfrom Jun 10, 2025
Merged
Conversation
Contributor
jonathandavies-arm
commented
Jun 3, 2025
- Fixes Arm64 SVE: Rename arguments for SVE CreateBreak/CreateMask APIs #115225
Contributor
Author
|
@a74nh @kunalspathak @dotnet/arm64-contrib |
kunalspathak
reviewed
Jun 3, 2025
| <?xml version="1.0" encoding="utf-8"?> | ||
| <!-- https://learn.microsoft.com/dotnet/fundamentals/package-validation/diagnostic-ids --> | ||
| <Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"> | ||
| <Suppression> |
Contributor
There was a problem hiding this comment.
I am not sure if this is the right file to update. Surprisingly, it doesn't even have reference of CreateBreakAfterMask that you have touched in this PR.
kunalspathak
suggested changes
Jun 3, 2025
Contributor
kunalspathak
left a comment
There was a problem hiding this comment.
can you please update the appropriate file to reflect the changes?
16 tasks
Contributor
|
Added When you commit this breaking change:
Tagging @dotnet/compat for awareness of the breaking change. |
Contributor
|
/ba-g failure unrelated |
Contributor
Since this is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.