Prepare cert tests for new signing algorithms#114416
Merged
bartonjs merged 3 commits intodotnet:mainfrom Apr 10, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
src/libraries/Common/tests/System/Security/Cryptography/X509Certificates/CertificateAuthority.cs:320
- Verify that the delegated CloneWithPrivateKey method robustly supports all key types (RSA, ECDsa, and DSA) and correctly converts from the generalized key type to the expected concrete instance.
return Common.CertificateAuthority.CloneWithPrivateKey(cert, key);
...rity.Cryptography/tests/X509Certificates/CertificateCreation/CertificateRequestChainTests.cs
Show resolved
Hide resolved
...s/System.Security.Cryptography/tests/X509Certificates/CertificateCreation/CrlBuilderTests.cs
Show resolved
Hide resolved
...libraries/Common/tests/System/Security/Cryptography/X509Certificates/CertificateAuthority.cs
Show resolved
Hide resolved
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
vcsjones
reviewed
Apr 9, 2025
...libraries/Common/tests/System/Security/Cryptography/X509Certificates/CertificateAuthority.cs
Outdated
Show resolved
Hide resolved
...libraries/Common/tests/System/Security/Cryptography/X509Certificates/CertificateAuthority.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/tests/TestUtilities/System/AssertExtensions.cs
Outdated
Show resolved
Hide resolved
...curity.Cryptography/tests/X509Certificates/CertificateCreation/PrivateKeyAssociationTests.cs
Outdated
Show resolved
Hide resolved
...curity.Cryptography/tests/X509Certificates/CertificateCreation/PrivateKeyAssociationTests.cs
Outdated
Show resolved
Hide resolved
This was referenced Apr 9, 2025
vcsjones
reviewed
Apr 9, 2025
...libraries/Common/tests/System/Security/Cryptography/X509Certificates/CertificateAuthority.cs
Outdated
Show resolved
Hide resolved
vcsjones
approved these changes
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the test infrastructure half of #114357.