Skip to content

SPMI: Ensure proper zero extension for isObjectImmutable and friends #112617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakobbotsch merged 1 commit into from
Feb 17, 2025
Merged

SPMI: Ensure proper zero extension for isObjectImmutable and friends #112617

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/coreclr/tools/superpmi/superpmi-shared/methodcontext.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2145,7 +2145,7 @@ void MethodContext::recGetRuntimeTypePointer(CORINFO_CLASS_HANDLE cls, CORINFO_O
GetRuntimeTypePointer = new LightWeightMap<DWORDLONG, DWORDLONG>();

DWORDLONG key = CastHandle(cls);
DWORDLONG value = (DWORDLONG)result;
DWORDLONG value = CastHandle(result);
GetRuntimeTypePointer->Add(key, value);
DEBUG_REC(dmpGetRuntimeTypePointer(key, value));
}
Expand All @@ -2166,7 +2166,7 @@ void MethodContext::recIsObjectImmutable(CORINFO_OBJECT_HANDLE objPtr, bool resu
if (IsObjectImmutable == nullptr)
IsObjectImmutable = new LightWeightMap<DWORDLONG, DWORD>();

DWORDLONG key = (DWORDLONG)objPtr;
DWORDLONG key = CastHandle(objPtr);
DWORD value = (DWORD)result;
IsObjectImmutable->Add(key, value);
DEBUG_REC(dmpIsObjectImmutable(key, value));
Expand All @@ -2177,7 +2177,7 @@ void MethodContext::dmpIsObjectImmutable(DWORDLONG key, DWORD value)
}
bool MethodContext::repIsObjectImmutable(CORINFO_OBJECT_HANDLE objPtr)
{
DWORDLONG key = (DWORDLONG)objPtr;
DWORDLONG key = CastHandle(objPtr);
DWORD value = LookupByKeyOrMiss(IsObjectImmutable, key, ": key %016" PRIX64 "", key);
DEBUG_REP(dmpIsObjectImmutable(key, value));
return (bool)value;
Expand Down Expand Up @@ -2224,8 +2224,8 @@ void MethodContext::recGetObjectType(CORINFO_OBJECT_HANDLE objPtr, CORINFO_CLASS
if (GetObjectType == nullptr)
GetObjectType = new LightWeightMap<DWORDLONG, DWORDLONG>();

DWORDLONG key = (DWORDLONG)objPtr;
DWORDLONG value = (DWORDLONG)result;
DWORDLONG key = CastHandle(objPtr);
DWORDLONG value = CastHandle(result);
GetObjectType->Add(key, value);
DEBUG_REC(dmpGetObjectType(key, value));
}
Expand All @@ -2235,7 +2235,7 @@ void MethodContext::dmpGetObjectType(DWORDLONG key, DWORDLONG value)
}
CORINFO_CLASS_HANDLE MethodContext::repGetObjectType(CORINFO_OBJECT_HANDLE objPtr)
{
DWORDLONG key = (DWORDLONG)objPtr;
DWORDLONG key = CastHandle(objPtr);
DWORDLONG value = LookupByKeyOrMiss(GetObjectType, key, ": key %016" PRIX64 "", key);
DEBUG_REP(dmpGetObjectType(key, value));
return (CORINFO_CLASS_HANDLE)value;
Expand Down
Loading