Fix condition in PAL's SetThreadDescription#109470
Merged
jkotas merged 2 commits intodotnet:mainfrom Nov 4, 2024
Merged
Conversation
janvorli
approved these changes
Nov 2, 2024
Member
janvorli
left a comment
There was a problem hiding this comment.
LGTM, thank you for a quick fix!
Member
Author
|
Thank you for the catch. Looks like we don't have test coverage for this path. 🥲 |
Member
|
Looks like another bug has been hiding behind the first one. This is failing when setting the name of PAL WorkerThread now. |
Member
|
/ba-g Known issues - mac queue deprecation, CLR_Tools timeout (#109520) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regressed in #108370 refactoring.