NativeAOT Thread Name by cshung · Pull Request #107943 · dotnet/runtime

cshung · 2024-09-17T18:55:09Z

No description provided.

src/coreclr/nativeaot/Runtime/unix/PalRedhawkUnix.cpp

src/coreclr/nativeaot/Runtime/windows/PalRedhawkMinWin.cpp

src/coreclr/nativeaot/Runtime/unix/PalRedhawkUnix.cpp

src/coreclr/nativeaot/Runtime/windows/PalRedhawkMinWin.cpp

src/coreclr/System.Private.CoreLib/src/System/Threading/Thread.CoreCLR.cs

src/coreclr/nativeaot/System.Private.CoreLib/src/System/Threading/Thread.NativeAot.cs

src/mono/System.Private.CoreLib/src/System/Threading/Thread.Mono.cs

src/coreclr/nativeaot/Runtime/unix/PalRedhawkUnix.cpp

src/coreclr/nativeaot/System.Private.CoreLib/src/System/Threading/Thread.NativeAot.cs

src/coreclr/nativeaot/System.Private.CoreLib/src/System/Runtime/RuntimeImports.cs

src/coreclr/nativeaot/Runtime/PalRedhawk.h

src/coreclr/nativeaot/Runtime/thread.cpp

src/coreclr/nativeaot/Runtime/windows/PalRedhawkMinWin.cpp

src/libraries/System.Private.CoreLib/src/System/Threading/Thread.cs

src/mono/System.Private.CoreLib/src/System/Threading/Thread.Mono.cs

src/coreclr/System.Private.CoreLib/src/System/Threading/Thread.CoreCLR.cs

src/coreclr/nativeaot/System.Private.CoreLib/src/System/Threading/Thread.NativeAot.cs

src/coreclr/nativeaot/Runtime/thread.cpp

src/coreclr/nativeaot/Runtime/unix/PalRedhawkUnix.cpp

src/coreclr/nativeaot/Runtime/windows/PalRedhawkMinWin.cpp

am11 · 2024-09-29T11:29:11Z

src/coreclr/vm/gcenv.ee.cpp

            assert(args != nullptr);

+#ifdef __APPLE__
+            SetThreadName(GetCurrentThread(), args->name);


@cshung, I think we can use it on all targets #108370?

@cshung, I think we can use it on all targets #108370?

Yes we can, but that would just be extra work since for all other platforms we have already set the name earlier.

src/coreclr/nativeaot/Runtime/unix/PalRedhawkUnix.cpp

jkotas

LGTM. Thank you!

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

cshung requested a review from MichalStrehovsky September 17, 2024 18:55

ghost added the area-NativeAOT-coreclr label Sep 17, 2024

cshung marked this pull request as draft September 17, 2024 18:55

dotnet-policy-service bot assigned cshung Sep 17, 2024

build-analysis bot mentioned this pull request Sep 17, 2024

restarted. Azure DevOps can't recover from restarts. dotnet/dnceng#3879

Closed

3 tasks

hez2010 reviewed Sep 18, 2024

View reviewed changes

src/coreclr/nativeaot/Runtime/unix/PalRedhawkUnix.cpp Outdated Show resolved Hide resolved

cshung marked this pull request as ready for review September 25, 2024 02:33

jkotas reviewed Sep 25, 2024

View reviewed changes

src/coreclr/nativeaot/Runtime/windows/PalRedhawkMinWin.cpp Outdated Show resolved Hide resolved

jkotas reviewed Sep 25, 2024

View reviewed changes

src/coreclr/nativeaot/Runtime/unix/PalRedhawkUnix.cpp Outdated Show resolved Hide resolved

cshung force-pushed the public/set-thread-name branch 3 times, most recently from 9e3dd91 to 746f9d0 Compare September 27, 2024 19:01

jkotas reviewed Sep 27, 2024

View reviewed changes

src/coreclr/nativeaot/Runtime/unix/PalRedhawkUnix.cpp Outdated Show resolved Hide resolved

jkotas reviewed Sep 27, 2024

View reviewed changes

src/coreclr/nativeaot/Runtime/windows/PalRedhawkMinWin.cpp Outdated Show resolved Hide resolved

jkotas reviewed Sep 27, 2024

View reviewed changes

src/coreclr/nativeaot/Runtime/windows/PalRedhawkMinWin.cpp Outdated Show resolved Hide resolved

build-analysis bot mentioned this pull request Sep 28, 2024

The hosted runner encountered an error while running your job. (Error Type: Disconnect). dotnet/dnceng#1919

Closed

3 tasks

cshung force-pushed the public/set-thread-name branch from 484beff to 1bbdef4 Compare September 28, 2024 23:44

cshung requested a review from marek-safar as a code owner September 28, 2024 23:44

jkotas reviewed Sep 29, 2024

View reviewed changes

src/libraries/System.Private.CoreLib/src/System/Threading/Thread.cs Outdated Show resolved Hide resolved

jkotas reviewed Sep 29, 2024

View reviewed changes

src/mono/System.Private.CoreLib/src/System/Threading/Thread.Mono.cs Outdated Show resolved Hide resolved

jkotas reviewed Sep 29, 2024

View reviewed changes

src/coreclr/System.Private.CoreLib/src/System/Threading/Thread.CoreCLR.cs Outdated Show resolved Hide resolved

jkotas reviewed Sep 29, 2024

View reviewed changes

src/coreclr/nativeaot/System.Private.CoreLib/src/System/Threading/Thread.NativeAot.cs Outdated Show resolved Hide resolved

jkotas reviewed Sep 29, 2024

View reviewed changes

src/coreclr/nativeaot/Runtime/thread.cpp Outdated Show resolved Hide resolved

jkotas reviewed Sep 29, 2024

View reviewed changes

src/coreclr/nativeaot/Runtime/unix/PalRedhawkUnix.cpp Outdated Show resolved Hide resolved

jkotas reviewed Sep 29, 2024

View reviewed changes

src/coreclr/nativeaot/Runtime/windows/PalRedhawkMinWin.cpp Outdated Show resolved Hide resolved

am11 reviewed Sep 29, 2024

View reviewed changes

cshung added 2 commits September 29, 2024 05:47

NativeAOT Thread Name

6a87825

Fix

1b85298

cshung force-pushed the public/set-thread-name branch from 790b9d9 to 1b85298 Compare September 29, 2024 12:58

jkotas reviewed Sep 29, 2024

View reviewed changes

src/coreclr/nativeaot/Runtime/unix/PalRedhawkUnix.cpp Outdated Show resolved Hide resolved

Update src/coreclr/nativeaot/Runtime/unix/PalRedhawkUnix.cpp

f58cb62

jkotas approved these changes Sep 29, 2024

View reviewed changes

build-analysis bot mentioned this pull request Sep 29, 2024

Error reported in diagnostic logs. Please examine the log for more details dotnet/dnceng#1928

Open

3 tasks

jkotas merged commit 2917e51 into dotnet:main Sep 29, 2024

cshung deleted the public/set-thread-name branch September 29, 2024 22:14

sirntar pushed a commit to sirntar/runtime that referenced this pull request Sep 30, 2024

NativeAOT Thread Name (dotnet#107943)

a4eba69

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

github-actions bot locked and limited conversation to collaborators Oct 30, 2024

Conversation

cshung commented Sep 17, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

am11 Sep 29, 2024

Choose a reason for hiding this comment

Uh oh!

cshung Sep 29, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jkotas left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants