Skip to content

Fix stack overflow in the configuration source gen#106511

Merged
ericstj merged 4 commits intodotnet:mainfrom
tarekgh:FixStackOverFlowInLoggingSourceGen
Aug 19, 2024
Merged

Fix stack overflow in the configuration source gen#106511
ericstj merged 4 commits intodotnet:mainfrom
tarekgh:FixStackOverFlowInLoggingSourceGen

Conversation

@tarekgh
Copy link
Member

@tarekgh tarekgh commented Aug 15, 2024

Fixes #103802

We'll need to port this to the rc2/release branch.

@tarekgh tarekgh added this to the 9.0.0 milestone Aug 15, 2024
@tarekgh tarekgh added the source-generator Indicates an issue with a source generator feature label Aug 15, 2024
@tarekgh tarekgh requested a review from ericstj August 15, 2024 22:53
@tarekgh tarekgh changed the title Fix stack overflow in the logging source gen Fix stack overflow in the configuration source gen Aug 16, 2024
Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericstj
Copy link
Member

ericstj commented Aug 19, 2024

/backport to release/9.0

@github-actions
Copy link
Contributor

Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/10461977265

@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Extensions-Configuration source-generator Indicates an issue with a source generator feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

StackOverflowException in Configuration.Binder source generator

2 participants