Reorder asserts in TypeBuilderState#106418
Merged
MichalStrehovsky merged 1 commit intodotnet:mainfrom Aug 14, 2024
Merged
Conversation
A newly added System.Reflection.Metadata test does `typeof(Nullable<>).MakeByRefType()`. We: 1. Actually attemt to build a `MethodTable` for this. I guess it's fine to make a `MethodTable` for it. 2. Hit an assert because we're trying to obtain a type loader template for this. Address 2 by reordering asserts so that we never try to look for template types of pointers/byrefs/function pointers.
Contributor
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
Member
Author
|
@dotnet/ilc-contrib the outerloop is currently failing due to a new test added in the past 24 hours or so. Would be really nice to get this in before the RC1 snap. |
Member
Author
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jkotas
approved these changes
Aug 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A newly added System.Reflection.Metadata test does
typeof(Nullable<>).MakeByRefType().We:
MethodTablefor this. I guess it's fine to make aMethodTablefor it.Address 2 by reordering asserts so that we never try to look for template types of pointers/byrefs/function pointers.
Cc @dotnet/ilc-contrib