[wasm][wasi] Allow to build wasi in library mode#102806
Merged
mkhamoyan merged 16 commits intodotnet:mainfrom Jun 7, 2024
Merged
[wasm][wasi] Allow to build wasi in library mode#102806mkhamoyan merged 16 commits intodotnet:mainfrom
mkhamoyan merged 16 commits intodotnet:mainfrom
Conversation
This was referenced May 29, 2024
maraf
reviewed
May 31, 2024
Member
|
Doesn't it fix #89577 as well? |
Contributor
Author
No, these changes are for |
Open
3 tasks
maraf
reviewed
Jun 5, 2024
src/mono/nuget/Microsoft.NET.Runtime.WebAssembly.Wasi.Sdk/Sdk/Sdk.props
Outdated
Show resolved
Hide resolved
maraf
reviewed
Jun 5, 2024
This was referenced Jun 5, 2024
Member
|
Is this waiting for other changes or ready to go? |
maraf
reviewed
Jun 6, 2024
Contributor
Author
@lewing It is ready to go unless there are further changes needed based on the review. |
Contributor
Author
|
Failures are not related to PR changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By this PR we are supporting library mode for wasi.
Here are all possibilites to build wasi.
Fixes #96869