2nd call to MemoryCache.Set() with the same key same size erases entry if cache is full#102420
Closed
pedrobsaila wants to merge 2 commits into
Closed
2nd call to MemoryCache.Set() with the same key same size erases entry if cache is full#102420pedrobsaila wants to merge 2 commits into
pedrobsaila wants to merge 2 commits into
Conversation
…y if cache is full
This was referenced May 26, 2024
ericstj
reviewed
Jun 24, 2024
|
|
||
| priorEntry?.InvokeEvictionCallbacks(); | ||
| } | ||
| else if (_options.HasSizeLimit && priorEntry != null && priorEntry.Size >= entry.Size) |
Member
There was a problem hiding this comment.
Would it be possible to avoid a separate case here by passing priorEntry to UpdateCacheSizeExceedsCapacity? @Tratcher mentioned in the issue that he thought the cause here was that that method didn't consider the size of the evicted item.
Member
There was a problem hiding this comment.
I agree, for this case we should run the same logic we run for not exceeding capacity.
Member
|
@dotnet/area-extensions-caching @mgravell or @sebastienros -- can one you have a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #36039