jitstress failure from recent pred list changes

[AndyAyersMS]

This is affecting about 150 test executions in jitstress and some in libraries jitstress too

Assert failure(PID 28 [0x0000001c], Thread: 41 [0x0029]): Assertion failed 'topBB->bbNum <= botBB->bbNum' in 'FsCheck.TypeClass+FromType@48:Invoke(System.Type):bool:this' during 'Set block order' (IL size 9; hash 0xf9ed1197; Tier0-FullOpts-MinOpts)

    File: /__w/1/s/src/coreclr/jit/optimizer.cpp Line: 4695
    Image: /root/helix/work/correlation/dotne

There is an assert in optReachWithoutCall invoked by fgSetBlockOrder that is triggered because we no longer have bbNum order in some unoptimized compiles. Turns out we don't actually depend on block order so I think I can just defer the assert.

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

---

This is affecting about 150 test executions in jitstress and some in libraries jitstress too

Assert failure(PID 28 [0x0000001c], Thread: 41 [0x0029]): Assertion failed 'topBB->bbNum <= botBB->bbNum' in 'FsCheck.TypeClass+FromType@48:Invoke(System.Type):bool:this' during 'Set block order' (IL size 9; hash 0xf9ed1197; Tier0-FullOpts-MinOpts)

    File: /__w/1/s/src/coreclr/jit/optimizer.cpp Line: 4695
    Image: /root/helix/work/correlation/dotne

There is an assert in optReachWithoutCall invoked by fgSetBlockOrder that is triggered because we no longer have bbNum order in some unoptimized compiles. Turns out we don't actually depend on block order so I think I can just defer the assert.

Author:	AndyAyersMS
Assignees:	-
Labels:	area-CodeGen-coreclr
Milestone:	-

[AndyAyersMS]

Likely caused by #80891