[iOS/tvOS] CustomAttributeDecoderTests.TestCustomAttributeDecoder failing on devices

[steveisok]

This test fails with:

System.BadImageFormatException : Invalid serialized string.
at System.Reflection.Throw.InvalidSerializedString()
   at System.Reflection.Metadata.BlobReader.ReadSerializedString()
   at System.Reflection.Metadata.Ecma335.CustomAttributeDecoder`1[[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].DecodeArgument(BlobReader& valueReader, ArgumentTypeInfo info)
   at System.Reflection.Metadata.Ecma335.CustomAttributeDecoder`1[[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].DecodeArrayArgument(BlobReader& blobReader, ArgumentTypeInfo info)
   at System.Reflection.Metadata.Ecma335.CustomAttributeDecoder`1[[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].DecodeArgument(BlobReader& valueReader, ArgumentTypeInfo info)
   at System.Reflection.Metadata.Ecma335.CustomAttributeDecoder`1[[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].DecodeFixedArguments(BlobReader& signatureReader, BlobReader& valueReader, Int32 count)
   at System.Reflection.Metadata.Ecma335.CustomAttributeDecoder`1[[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].DecodeValue(EntityHandle constructor, BlobHandle value)
   at System.Reflection.Metadata.CustomAttribute.DecodeValue[String](ICustomAttributeTypeProvider`1 provider)
   at System.Reflection.Metadata.Decoding.Tests.CustomAttributeDecoderTests.TestCustomAttributeDecoder()
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

Tagging subscribers to this area: @buyaa-n
See info in area-owners.md if you want to be subscribed.

Issue Details

---

This test fails with:

System.BadImageFormatException : Invalid serialized string.
at System.Reflection.Throw.InvalidSerializedString()
   at System.Reflection.Metadata.BlobReader.ReadSerializedString()
   at System.Reflection.Metadata.Ecma335.CustomAttributeDecoder`1[[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].DecodeArgument(BlobReader& valueReader, ArgumentTypeInfo info)
   at System.Reflection.Metadata.Ecma335.CustomAttributeDecoder`1[[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].DecodeArrayArgument(BlobReader& blobReader, ArgumentTypeInfo info)
   at System.Reflection.Metadata.Ecma335.CustomAttributeDecoder`1[[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].DecodeArgument(BlobReader& valueReader, ArgumentTypeInfo info)
   at System.Reflection.Metadata.Ecma335.CustomAttributeDecoder`1[[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].DecodeFixedArguments(BlobReader& signatureReader, BlobReader& valueReader, Int32 count)
   at System.Reflection.Metadata.Ecma335.CustomAttributeDecoder`1[[System.String, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].DecodeValue(EntityHandle constructor, BlobHandle value)
   at System.Reflection.Metadata.CustomAttribute.DecodeValue[String](ICustomAttributeTypeProvider`1 provider)
   at System.Reflection.Metadata.Decoding.Tests.CustomAttributeDecoderTests.TestCustomAttributeDecoder()
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

Author:	steveisok
Assignees:	-
Labels:	area-System.Reflection.Metadata, untriaged
Milestone:	-

[steveharter]

@steveisok was this failing in normal CI simulators like for runtime (Build tvOSSimulator x64 Debug AllSubsets_Mono) or only on physical devices?

[steveisok]

I believe it was only devices

[steveharter]

Per the test PR at https://github.com/dotnet/runtime/pull/72224/files that test is passing on simulators so it must be devices then.

The current test hard-codes "System.Runtime" as the module which since it works in CI should be fine unless these perhaps use single-file executables on the device?

[steveharter]

Moving to 8.0; lower-priority and need to verify on devices.