TryAddWithoutValidation for multiple values could be more efficient#4240
Open
pedrobsaila wants to merge 3 commits intodotnet:mainfrom
Open
TryAddWithoutValidation for multiple values could be more efficient#4240pedrobsaila wants to merge 3 commits intodotnet:mainfrom
pedrobsaila wants to merge 3 commits intodotnet:mainfrom
Conversation
MihaZupan
reviewed
May 29, 2024
Member
MihaZupan
left a comment
There was a problem hiding this comment.
Thank you for the improving coverage here
| namespace System.Net.Http.Tests | ||
| { | ||
| [BenchmarkCategory(Categories.Libraries, Categories.LINQ)] | ||
| public class TryAddWithoutValidationTests |
Member
There was a problem hiding this comment.
Please make a new class for HttpHeaders instead, with this being one of the tested methods there
|
|
||
| namespace System.Net.Http.Tests | ||
| { | ||
| [BenchmarkCategory(Categories.Libraries, Categories.LINQ)] |
Member
There was a problem hiding this comment.
Suggested change
| [BenchmarkCategory(Categories.Libraries, Categories.LINQ)] | |
| [BenchmarkCategory(Categories.Libraries)] |
| { | ||
| [Benchmark] | ||
| [ArgumentsSource(nameof(IEnumerableArgument))] | ||
| public bool AddHeaders(AddWithoutValidationTestData data) => new HttpResponseMessage().Headers.TryAddWithoutValidation("headerName", data.Values); |
Member
There was a problem hiding this comment.
We could make the test more focused on just the adding part, e.g.
private readonly HttpResponseHeaders _responseHeaders = new HttpResponseMessage().Headers;
public bool SomeTest()
{
_responseHeaders.Add(...);
_responseHeaders.Clear();
}
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to dotnet/runtime#64049