Perf Utf8Encoding for ARM64 comparison#1466
Merged
adamsitnik merged 2 commits intodotnet:masterfrom Aug 24, 2020
carlossanlop:encoding
Merged
Perf Utf8Encoding for ARM64 comparison#1466adamsitnik merged 2 commits intodotnet:masterfrom carlossanlop:encoding
adamsitnik merged 2 commits intodotnet:masterfrom
carlossanlop:encoding
Conversation
Contributor
Author
|
Results: SSE2 OFF vs SSE2 ONOff: AdvSimd OFF vs AdvSimd ONOff: |
adamsitnik
approved these changes
Aug 20, 2020
Member
adamsitnik
left a comment
There was a problem hiding this comment.
LGTM, thank you @carlossanlop !
|
I'm just wondering if this will break the mono CI too. |
|
Maybe not. I just saw that @adamsitnik fixed the mono issue with a NoMono category. Nice! |
Member
This one not because it's not using the forbidden constructor :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to verify the performance of the recent AdvSimd.Arm64 improvements added to Utf16Utility.Validation.cs.
The
UTF8Encoding.GetByteCountmethod reaches the Utf16Utility.Validation.cs lines 82, 150 and 190, when called with the contents of the recently added text files containing long unicode strings.cc @kunalspathak @pgovind @adamsitnik