Skip to content

Add 'Request Speedometer Perf Run' to VS experimental insertion build policies#13505

Merged
JanProvaznik merged 2 commits into
mainfrom
copilot/update-insertion-build-policies
Apr 8, 2026
Merged

Add 'Request Speedometer Perf Run' to VS experimental insertion build policies#13505
JanProvaznik merged 2 commits into
mainfrom
copilot/update-insertion-build-policies

Conversation

Copilot AI commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

Adds the Request Speedometer Perf Run policy to the experimental VS insertion pipeline alongside the existing Request Perf DDRITs policy.

Context

The experimental insertion was missing the Speedometer perf run policy, meaning that performance gate was not being triggered on experimental insertions.

Changes Made

  • azure-pipelines/vs-insertion-experimental.yml: Added Request Speedometer Perf Run to InsertionBuildPolicies (comma-separated, matching the multi-policy format)
InsertionBuildPolicies: 'Request Perf DDRITs,Request Speedometer Perf Run'

Testing

Pipeline configuration change only — no code logic affected.

Notes

The regular (non-experimental) insertion pipeline should be checked to ensure parity if needed.

Original prompt

In azure-pipelines/vs-insertion-experimental.yml at line 158, the InsertionBuildPolicies currently only includes 'Request Perf DDRITs'.

Update line 158 to also include the 'Request Speedometer Perf Run' policy. The updated line should be:

            InsertionBuildPolicies: 'Request Perf DDRITs,Request Speedometer Perf Run'

This is the same format used for multiple policies — comma-separated within a single quoted string.

The following is the prior conversation context from the user's chat exploration (may be truncated):

User: InsertionBuildPolicies: 'Request Perf DDRITs'
also add policy 'Request Speedometer Perf Run'

Assistant:

Let me first look at the current file to understand the context around line 158.

Assistant: I can see the file. Line 158 currently has InsertionBuildPolicies: 'Request Perf DDRITs' and you'd like to also add 'Request Speedometer Perf Run'. Let me create a PR for this change.

Assistant: I've kicked off the Copilot coding agent to create a pull request that adds 'Request Speedometer Perf Run' to the InsertionBuildPolicies on line 158 of azure-pipelines/vs-insertion-experimental.yml. The updated line will be:

            InsertionBuildPolicies: 'Request Perf DDRITs,Request Speedometer Perf Run'

You'll receive a notification once the PR is ready for review.

This pull request was created from Copilot chat.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Hello @@copilot, I noticed that you’re changing an .swr file or any file under src/Package/MSBuild.VSSetup.. Please make sure to validate this change by an experimental VS insertion. This is accomplished by pushing to an exp/* branch, which requires write permissions to this repo.

…sertion-experimental.yml

Agent-Logs-Url: https://github.com/dotnet/msbuild/sessions/155800df-e886-409c-b095-aa57cb256cd7

Co-authored-by: JanProvaznik <25267098+JanProvaznik@users.noreply.github.com>
@JanProvaznik JanProvaznik requested a review from a team April 8, 2026 12:13
Copilot AI changed the title [WIP] Update InsertionBuildPolicies to include Speedometer Perf Run Add 'Request Speedometer Perf Run' to VS experimental insertion build policies Apr 8, 2026
Copilot AI requested a review from JanProvaznik April 8, 2026 12:14
@JanProvaznik JanProvaznik marked this pull request as ready for review April 8, 2026 13:24
Copilot AI review requested due to automatic review settings April 8, 2026 13:24
@JanProvaznik JanProvaznik enabled auto-merge (squash) April 8, 2026 13:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds the missing Speedometer performance gate to the experimental VS insertion pipeline so experimental insertions trigger the same additional perf policy intended for insertions.

Changes:

  • Updates the experimental VS insertion pipeline to request both DDRIT perf runs and Speedometer perf runs via InsertionBuildPolicies.

@JanProvaznik JanProvaznik merged commit cbe2bab into main Apr 8, 2026
14 checks passed
@JanProvaznik JanProvaznik deleted the copilot/update-insertion-build-policies branch April 8, 2026 16:10
dfederm pushed a commit to dfederm/msbuild that referenced this pull request Apr 9, 2026
… policies (dotnet#13505)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: JanProvaznik <25267098+JanProvaznik@users.noreply.github.com>
This was referenced Jun 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants